update timestamp regex; add iri check for signoff phase instrument

Author: elichad

rocrate_validator/profiles/five-safes-crate/may/4_sign_off.ttl

@@ -51,7 +51,7 @@ five-safes-crate:SignOffPhaseStartTime
         sh:path schema:startTime ;
         sh:minCount 1 ;
         sh:maxCount 1 ;
-        sh:pattern "^[0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}(Z|[+-][0-9]{2}:[0-9]{2})$" ;
+        sh:pattern "^[0-9]{4}-[0-9]{2}-[0-9]{2}[Tt][0-9]{2}:[0-9]{2}:[0-9]{2}([.|,][0-9]+)?(Z|z|[+-][0-9]{2}:[0-9]{2})$" ;
         sh:severity sh:Info ;
         sh:description "Sign Off object MAY have a startTime property if action is active, completed or failed. This must follow ISO-8601 syntax" ;
         sh:message "Sign Off object MAY have a startTime property if action is active, completed or failed. This must follow ISO-8601 syntax" ;

rocrate_validator/profiles/five-safes-crate/should/4_sign_off.ttl

@@ -91,6 +91,7 @@ five-safes-crate:SignOffPhaseProperties
         sh:description "Check if the Sign Off phase has an instrument (TRE Policy)" ;
         sh:path schema:instrument ;
         sh:class schema:CreativeWork ;
+        sh:nodeKind sh:IRI;
         sh:minCount 1 ;
         sh:severity sh:Warning ;
         sh:message "The Sign-Off Phase SHOULD have an TRE policy (instrument) with type CreativeWork" ;
@@ -170,7 +171,7 @@ five-safes-crate:SignOffPhaseEndTime
         sh:path schema:endTime ;
         sh:minCount 1 ;
         sh:maxCount 1 ;
-        sh:pattern "^[0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}(Z|[+-][0-9]{2}:[0-9]{2})$" ;
+        sh:pattern "^[0-9]{4}-[0-9]{2}-[0-9]{2}[Tt][0-9]{2}:[0-9]{2}:[0-9]{2}([.|,][0-9]+)?(Z|z|[+-][0-9]{2}:[0-9]{2})$" ;
         sh:severity sh:Warning ;
         sh:description "Sign Off object SHOULD have endTime property if action completed or failed. This must follow ISO-8601 syntax" ;
         sh:message "Sign Off object SHOULD have endTime property if action completed or failed. This must follow ISO-8601 syntax" ;

tests/integration/profiles/five-safes-crate/test_5src_4_signoff_phase.py

@@ -412,6 +412,39 @@ def test_5src_signoff_phase_no_instrument():
         rocrate_entity_mod_sparql=sparql,
     )
 
+def test_5src_signoff_phase_instrument_not_iri():
+    """
+    Test a Five Safes Crate where the Sign-Off phase TRE policy (instrument) is not an IRI.
+    """
+    sparql = (
+        SPARQL_PREFIXES
+        + """
+        DELETE {
+            ?signoff schema:instrument ?instrument .
+        }
+        INSERT {
+            ?signoff schema:instrument "Not a cross-reference" .
+        }
+        WHERE {
+           ?signoff a schema:AssessAction ;
+               schema:additionalType <https://w3id.org/shp#SignOff> ;
+               schema:instrument ?instrument .
+        }
+        """
+    )
+
+    do_entity_test(
+        rocrate_path=ValidROC().five_safes_crate_result,
+        requirement_severity=Severity.RECOMMENDED,
+        expected_validation_result=False,
+        expected_triggered_requirements=["SignOffPhaseProperties"],
+        expected_triggered_issues=[
+            "The Sign-Off Phase SHOULD have an TRE policy (instrument) with type CreativeWork"
+        ],
+        profile_identifier="five-safes-crate",
+        rocrate_entity_mod_sparql=sparql,
+    )
+
 
 def test_5src_signoff_phase_instrument_no_type():
     """