fix: normalize Windows path separators across operations (#51)

* fix: normalize path separators in tarball file system

* chore: change variable name to `normalizePath`

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

* chore: change variable name to `normalizedPath`

* fix: remove unnecessary path normalization

* fix: windows path separators

* fix: windows path separators

---------

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

Author: outslept

src/analyze/dependencies.ts

@@ -7,6 +7,7 @@ import type {
   Stats
 } from '../types.js';
 import {FileSystem} from '../file-system.js';
+import {normalizePath} from '../utils/path.js';
 
 interface DependencyNode {
   name: string;
@@ -214,7 +215,7 @@ export async function runDependencyAnalysis(
     const allDeps = {...depPkg.dependencies, ...depPkg.devDependencies};
     for (const depName of Object.keys(allDeps)) {
       let packageMatch = packageFiles.find((packageFile) =>
-        packageFile.endsWith(`/node_modules/${depName}/package.json`)
+        normalizePath(packageFile).endsWith(`/node_modules/${depName}/package.json`)
       );
 
       if (!packageMatch) {
@@ -247,7 +248,8 @@ export async function runDependencyAnalysis(
   // find the ones that don't exist in the parent package's dependency list.
   // there must be a better way
   for (const file of packageFiles) {
-    if (file === rootDir + '/package.json') {
+    const rootPackageJsonPath = normalizePath(rootDir) + '/package.json';
+    if (file === rootPackageJsonPath) {
       continue;
     }
 
@@ -264,7 +266,8 @@ export async function runDependencyAnalysis(
 
       if (!alreadyExists) {
         // Extract path information from the file path
-        const pathParts = file.split('/node_modules/');
+        const normalizedFile = normalizePath(file);
+        const pathParts = normalizedFile.split('/node_modules/');
         if (pathParts.length > 1) {
           const packageDirName = pathParts[pathParts.length - 1].replace(
             '/package.json',

src/local-file-system.ts

@@ -4,6 +4,7 @@ import * as fs from 'node:fs/promises';
 import {type Logger, pino} from 'pino';
 import {fdir} from 'fdir';
 import {readFile, stat} from 'node:fs/promises';
+import {normalizePath} from './utils/path.js';
 
 export class LocalFileSystem implements FileSystem {
   #root: string;
@@ -35,10 +36,13 @@ export class LocalFileSystem implements FileSystem {
       const crawler = new fdir()
         .withFullPaths()
         .withSymlinks()
-        .filter((filePath) => filePath.endsWith('/package.json'))
+        .filter((filePath) => normalizePath(filePath).endsWith('/package.json'))
         .crawl(nodeModulesPath);
       const files = await crawler.withPromise();
-      return files.map((file) => `/${path.relative(this.#root, file)}`);
+      return files.map((file) => {
+        const relativePath = path.relative(this.#root, file);
+        return '/' + normalizePath(relativePath);
+      });
     } catch {
       return [];
     }

src/tarball-file-system.ts

@@ -36,7 +36,7 @@ export class TarballFileSystem implements FileSystem {
 
   async readFile(filePath: string): Promise<string> {
     const {files} = await this.#getUnpackResult();
-    const fullPath = path.join(await this.getRootDir(), filePath);
+    const fullPath = path.posix.join(await this.getRootDir(), filePath);
     const file = files.find((f) => f.name === fullPath);
     if (!file) {
       throw new Error(`File not found: ${filePath}`);

src/utils/path.ts

@@ -0,0 +1,3 @@
+export function normalizePath(path: string): string {
+  return path.replaceAll('\\', '/');
+}