Skip to content

Commit d3c6bd9

Browse files
Update results job to check skip_workflow on all declared dependencies (#13353)
* Initial plan * Update results job to check skip_workflow on all declared dependencies Co-authored-by: captainsafia <[email protected]> * Add comment explaining skip_workflow check behavior for all dependencies Co-authored-by: captainsafia <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: captainsafia <[email protected]>
1 parent 49eb5f0 commit d3c6bd9

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

.github/workflows/ci.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,13 +86,18 @@ jobs:
8686
steps:
8787
- name: Fail if any of the dependent jobs failed
8888
# Don't fail if the workflow is being skipped.
89+
# Check skip_workflow on all declared dependencies. Workflows without
90+
# skip_workflow outputs (e.g., tests, build_cli_archives) evaluate to
91+
# empty string, so the check still works ('!= true' is true for empty).
8992
#
9093
# For others 'skipped' can be when a transitive dependency fails and the dependent job gets
9194
# 'skipped'. For example, one of setup_* jobs failing and the Integration test jobs getting
9295
# 'skipped'
9396
if: >-
9497
${{ always() &&
9598
needs.prepare_for_ci.outputs.skip_workflow != 'true' &&
99+
needs.tests.outputs.skip_workflow != 'true' &&
100+
needs.build_cli_archives.outputs.skip_workflow != 'true' &&
96101
(contains(needs.*.result, 'failure') ||
97102
contains(needs.*.result, 'cancelled') ||
98103
contains(needs.*.result, 'skipped')) }}

0 commit comments

Comments
 (0)