Add test for Karui fragment, cleanup code and unused property

Author: domialex

src/Sidekick.Business/Apis/Poe/Parser/ItemSections.cs

@@ -25,8 +25,6 @@ public ItemSections(string[][] splitSections, string[] wholeSections)
 
         public string MapPropertiesSection => WholeSections[1];
 
-        public string MapInfluenceSection => WholeSections[3];
-
         public string NameLine => HeaderSection.Length > 1 ? HeaderSection[1] : string.Empty;
 
         public string TypeLine => HeaderSection.Length > 2 ? HeaderSection[2] : string.Empty;

src/Sidekick.Business/Apis/Poe/Parser/ParserService.cs

@@ -191,7 +191,7 @@ private void ParseGem(Item item, ItemSections itemSections)
 
         private bool ParseFromEnd(Regex pattern, ItemSections itemSections)
         {
-            if (itemSections.WholeSections.Count() < 3)
+            if (itemSections.WholeSections.Length < 3)
                 return false;
 
             // Section order at the end:

tests/Sidekick.Business.Tests/ItemParserTests/MapParsing.cs

@@ -4,6 +4,7 @@
 using FluentAssertions.Execution;
 using NUnit.Framework;
 using Sidekick.Business.Apis.Poe.Parser;
+using Sidekick.Business.Apis.Poe.Trade.Data.Items;
 
 namespace Sidekick.Business.Tests.ItemParserTests
 {
@@ -90,6 +91,18 @@ public async Task ParseOccupiedMap()
             }
         }
 
+        [Test]
+        public async Task ParseTimelessKaruiEmblem()
+        {
+            var actual = await Subject.ParseItem(TimelessKaruiEmblem);
+
+            using (new AssertionScope())
+            {
+                actual.Type.Should().Be("Timeless Karui Emblem");
+                actual.Category.Should().Be(Category.Map);
+            }
+        }
+
         #region ItemText
 
         private const string NormalMap = @"Rarity: Normal
@@ -185,6 +198,11 @@ Players gain 50% reduced Flask Charges
 --------
 Travel to this Map by using it in a personal Map Device. Maps can only be used once.";
 
+        private const string TimelessKaruiEmblem = @"Rarity: Normal
+Timeless Karui Emblem
+--------
+Place two or more different Emblems in a Map Device to access the Domain of Timeless Conflict. Can only be used once.";
+
         #endregion
     }
 }

tests/Sidekick.Business.Tests/ItemParserTests/MiscParsing.cs

@@ -4,6 +4,7 @@
 using NUnit.Framework;
 using Sidekick.Business.Apis.Poe.Models;
 using Sidekick.Business.Apis.Poe.Parser;
+using Sidekick.Business.Apis.Poe.Trade.Data.Items;
 
 namespace Sidekick.Business.Tests.ItemParserTests
 {
@@ -66,7 +67,7 @@ public async Task ParseOrgan()
             using (new AssertionScope())
             {
                 actual.Rarity.Should().Be(Rarity.Unique);
-                actual.Category.Should().Be(Apis.Poe.Trade.Data.Items.Category.ItemisedMonster);
+                actual.Category.Should().Be(Category.ItemisedMonster);
                 actual.Type.Should().Be("Portentia, the Foul");
             }
         }