fix: address PR #35 review comments

- Log effective result.Source instead of hardcoded 'file_path' when
  nested_workspace_override is active (comment #1)
- Add TestResolveFilePathNestedWorkspaceOverride to resolver_test.go
  verifying parent root, source, and reduced confidence (comment #2)
- Use TrimRight on entryRoot before appending separator in
  FindParentWorkspace to prevent double separator on root paths
  like '/' or 'C:\' (comment #3)

Author: razvan

pkg/workspace/registry/registry.go

@@ -263,8 +263,9 @@ func (r *Registry) FindParentWorkspace(path string) (string, bool) {
 
 	for _, entry := range r.entries {
 		entryRoot := strings.ToLower(filepath.Clean(entry.Root))
-		// The path must be strictly inside the entry root (not equal to it)
-		prefix := entryRoot + string(filepath.Separator)
+		// The path must be strictly inside the entry root (not equal to it).
+		// TrimRight avoids double separator when entryRoot is "/" or "C:\".
+		prefix := strings.TrimRight(entryRoot, string(filepath.Separator)) + string(filepath.Separator)
 		if strings.HasPrefix(cleanPath, prefix) {
 			// Pick the deepest (most specific) parent
 			if len(entryRoot) > bestLen {

pkg/workspace/resolver/resolver.go

@@ -185,7 +185,7 @@ func (r *Resolver) handleFilePath(ctx context.Context, path string) (*contract.R
 		}
 	}
 
-	r.log(ctx, "file_path", map[string]any{"root": result.Root, "source": "file_path"})
+	r.log(ctx, "file_path", map[string]any{"root": result.Root, "source": result.Source})
 	if result.Source == "" {
 		result.Source = "file_path"
 	}

pkg/workspace/resolver/resolver_test.go

@@ -56,6 +56,32 @@ func TestResolveFilePath(t *testing.T) {
 	}
 }
 
+func TestResolveFilePathNestedWorkspaceOverride(t *testing.T) {
+	// Detector finds /tmp/parent/nested as the workspace root (has its own .git)
+	detector := &fakeDetector{candidate: &contract.WorkspaceCandidate{
+		Root:   "/tmp/parent/nested",
+		Reason: contract.ReasonFilePath,
+	}}
+	// Registry knows /tmp/parent is an already-registered workspace
+	reg := &fakeRegistry{parentRoot: "/tmp/parent"}
+	r := New(Dependencies{Detector: detector, Registry: reg})
+	req := contract.ResolveWorkspaceRequest{FilePath: "/tmp/parent/nested/src/main.py"}
+
+	resp, err := r.Resolve(context.Background(), req)
+	if err != nil {
+		t.Fatalf("unexpected error: %v", err)
+	}
+	if resp.ResolvedRoot != "/tmp/parent" {
+		t.Fatalf("expected parent root /tmp/parent, got %s", resp.ResolvedRoot)
+	}
+	if resp.PathResolutionSource != "nested_workspace_override" {
+		t.Fatalf("expected source nested_workspace_override, got %s", resp.PathResolutionSource)
+	}
+	if resp.PathResolutionConfidence >= 0.95 {
+		t.Fatalf("expected reduced confidence (<0.95), got %f", resp.PathResolutionConfidence)
+	}
+}
+
 func TestResolveAlias(t *testing.T) {
 	registry := &fakeRegistry{candidate: &contract.WorkspaceCandidate{Root: "/tmp/alias", Reason: contract.ReasonWorkspaceAlias}}
 	r := New(Dependencies{Registry: registry})
@@ -235,6 +261,7 @@ type fakeRegistry struct {
 	err           *contract.ResolveWorkspaceError
 	feedbackCount int
 	promoteCount  int
+	parentRoot    string // if set, FindParentWorkspace returns this
 }
 
 func (f *fakeRegistry) ResolveAlias(ctx context.Context, alias string) (*contract.WorkspaceCandidate, *contract.ResolveWorkspaceError) {
@@ -268,6 +295,9 @@ func (f *fakeRegistry) GetActiveWorkspace() (string, error) {
 }
 
 func (f *fakeRegistry) FindParentWorkspace(path string) (string, bool) {
+	if f.parentRoot != "" {
+		return f.parentRoot, true
+	}
 	return "", false
 }