refactor: implement final review feedback for workspace detection and tool evaluation

Author: doITmagic

.github/workflows/release.yml

@@ -27,11 +27,11 @@ jobs:
         id: check_token
         run: |
           if [ -n "${{ secrets.HOMEBREW_TAP_TOKEN }}" ]; then
-            echo "HAS_TAP_TOKEN=true" >> $GITHUB_OUTPUT
-            echo "HOMEBREW_TAP_TOKEN is present. Using it for Homebrew updates."
+            echo "SKIP_HOMEBREW=" >> $GITHUB_OUTPUT
+            echo "HOMEBREW_TAP_TOKEN is present. Homebrew updates enabled."
           else
-            echo "HAS_TAP_TOKEN=false" >> $GITHUB_OUTPUT
-            echo "HOMEBREW_TAP_TOKEN is missing. Homebrew Tap update will be skipped or may fail if GITHUB_TOKEN has no cross-repo access."
+            echo "SKIP_HOMEBREW=--skip=homebrew" >> $GITHUB_OUTPUT
+            echo "HOMEBREW_TAP_TOKEN is missing. Homebrew Tap update will be skipped."
           fi
       
       - name: Fetch all tags
@@ -48,10 +48,10 @@ jobs:
         with:
           distribution: goreleaser
           version: v2.6.1
-          args: release --clean
+          args: release --clean ${{ steps.check_token.outputs.SKIP_HOMEBREW }}
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          HOMEBREW_TAP_TOKEN: ${{ secrets.HOMEBREW_TAP_TOKEN || secrets.GITHUB_TOKEN }}
+          HOMEBREW_TAP_TOKEN: ${{ secrets.HOMEBREW_TAP_TOKEN }}
 
       - name: Update server.json version
         run: |

.goreleaser.yaml

@@ -187,7 +187,7 @@ brews:
   - repository:
       owner: doITmagic
       name: homebrew-tap
-      # Use a dedicated token if available, otherwise fallback to GITHUB_TOKEN
+      # REQUIRED: A dedicated token (HOMEBREW_TAP_TOKEN) with write access to the tap repository.
       token: "{{ .Env.HOMEBREW_TAP_TOKEN }}"
 
     directory: Formula

README.md

@@ -148,6 +148,9 @@ First query triggers background indexing. Subsequent queries are instant.
 - **Without RagCode:** AI reads 5-10 files (~15,000 tokens) to find a function
 - **With RagCode:** AI gets exact function + context (~200 tokens)
 
+> [!TIP]
+> **Token Management:** By default, search tools return the top **5 most relevant results**. This is optimized to provide high-quality context while keeping token usage low. You can customize this by passing a `limit` parameter to any search tool.
+
 ### RagCode vs Cloud-Based Solutions
 
 | Feature | RagCode (Local) | Cloud AI Search |

cmd/rag-code-mcp/main.go

@@ -1357,8 +1357,20 @@ func extractFilePathsFromRoots(roots []*mcp.Root) []string {
 	var rootPaths []string
 	for _, r := range roots {
 		u, err := url.Parse(r.URI)
-		if err == nil && u.Scheme == "file" {
-			rootPaths = append(rootPaths, u.Path)
+		if err != nil {
+			logger.Warn("Failed to parse workspace root URI %s: %v", r.URI, err)
+			continue
+		}
+
+		if u.Scheme == "file" {
+			path := u.Path
+			// On Windows, the path might be /C:/path, trim the leading slash
+			if len(path) > 2 && path[0] == '/' && path[2] == ':' {
+				path = path[1:]
+			}
+			rootPaths = append(rootPaths, path)
+		} else {
+			logger.Warn("Workspace root URI scheme %q is not supported: %s. Only 'file://' roots are registered automatically for local indexing.", u.Scheme, r.URI)
 		}
 	}
 	return rootPaths

docs/CONFIGURATION.md

@@ -30,6 +30,11 @@ llm:
   model: "phi3:medium"        # LLM for code analysis
   embed_model: "mxbai-embed-large"  # Embedding model
 
+> [!WARNING]
+> **Model Naming:** When specifying models, use the exact name as shown in `ollama list`.
+> RagCode automatically handles the implicit `:latest` tag (e.g., `model` matches `model:latest`).
+> If you use a specific tag like `:v1`, ensure it is included both in your config and in your `ollama pull` command.
+
 storage:
   vector_db:
     url: "http://localhost:6333"

internal/healthcheck/healthcheck.go

@@ -79,25 +79,36 @@ func CheckOllamaWithModels(baseURL string, requiredModels []string) CheckResult
 			return result
 		}
 
-		installed := make(map[string]bool)
-		for _, m := range tags.Models {
-			installed[m.Name] = true
-			// Also track without :latest tag
-			if strings.HasSuffix(m.Name, ":latest") {
-				installed[strings.TrimSuffix(m.Name, ":latest")] = true
+		// Normalize helper: returns model name and tag
+		normalize := func(name string) (string, string) {
+			if !strings.Contains(name, ":") {
+				return name, "latest"
 			}
+			parts := strings.SplitN(name, ":", 2)
+			return parts[0], parts[1]
 		}
 
 		var missing []string
 		for _, req := range requiredModels {
-			if !installed[req] {
+			reqBase, reqTag := normalize(req)
+			found := false
+
+			for _, m := range tags.Models {
+				mBase, mTag := normalize(m.Name)
+				if reqBase == mBase && reqTag == mTag {
+					found = true
+					break
+				}
+			}
+
+			if !found {
 				missing = append(missing, req)
 			}
 		}
 
 		if len(missing) > 0 {
 			result.Status = "error"
-			result.Message = fmt.Sprintf("Missing models: %s", strings.Join(missing, ", "))
+			result.Message = fmt.Sprintf("Missing models: %s (Ollama implicit :latest tag might cause mismatch if you have specific versions installed)", strings.Join(missing, ", "))
 			return result
 		}
 

internal/ragcode/analyzers/generic/analyzer.go

@@ -120,7 +120,7 @@ func (a *CodeAnalyzer) shouldSkipDir(path, root string) bool {
 		return true
 	}
 	switch base {
-	case "node_modules", "vendor", "dist", "build", "public", "tmp":
+	case "node_modules", "vendor", "dist", "build":
 		return true
 	default:
 		return false

internal/ragcode/analyzers/html/analyzer.go

@@ -187,7 +187,7 @@ func shouldSkipDir(path, root string) bool {
 		return true
 	}
 	switch base {
-	case "node_modules", "vendor", "dist", "build", "public", "tmp":
+	case "node_modules", "vendor", "dist", "build":
 		return true
 	default:
 		return false

internal/tools/evaluate_ragcode.go

@@ -24,14 +24,14 @@ func (t *EvaluateRagCodeTool) Name() string {
 }
 
 func (t *EvaluateRagCodeTool) Description() string {
-	return "Request a performance and quality evaluation of RagCode MCP from the AI assistant's perspective. Use this to provide feedback on benefits, pain points, and suggest improvements. IMPORTANT: Always provide the 'file_path' of the file you are currently working on for better context detection."
+	return "Request a performance and quality evaluation of RagCode MCP from the AI assistant's perspective. Use this to provide feedback on benefits, pain points, and suggest improvements. RECOMMENDED: Providing the 'file_path' helps identifies the current project context for a more accurate evaluation, but it is not strictly mandatory."
 }
 
 func (t *EvaluateRagCodeTool) Execute(ctx context.Context, args map[string]interface{}) (string, error) {
 	log.Printf("[INFO] 🛠️ Executing tool '%s'\n", t.Name())
 
 	// Detect workspace for context, but continue gracefully if it fails
-	info, err := t.wm.DetectWorkspace(args)
+	info, err := DetectAndRegisterWorkspace(t.wm, args)
 	var languages []string
 	if err != nil {
 		// For evaluation, lack of workspace context should not be fatal; log and continue.
@@ -76,7 +76,7 @@ func (t *EvaluateRagCodeTool) Execute(ctx context.Context, args map[string]inter
 		builder.WriteString(fmt.Sprintf("- **Workspace**: %s\n", info.Root))
 		builder.WriteString(fmt.Sprintf("- **Languages**: %s\n", strings.Join(languages, ", ")))
 	} else {
-		builder.WriteString("- **Workspace**: Not detected (fallback mode)\n")
+		builder.WriteString("- **Workspace**: Not detected (fallback mode). This means RagCode is using global settings because it couldn't identify a specific project root. To enable workspace-specific context, please ensure you provide a 'file_path' of a file within the project in your tool requests.\n")
 	}
 	builder.WriteString(fmt.Sprintf("- **System Status**:\n%s\n", strings.Join(healthStatus, "\n")))
 	builder.WriteString(fmt.Sprintf("- **Models**: Chat=%s, Embed=%s\n\n", cfg.LLM.OllamaModel, cfg.LLM.OllamaEmbed))

internal/tools/find_implementations.go

@@ -64,7 +64,7 @@ func (t *FindImplementationsTool) Execute(ctx context.Context, args map[string]i
 	var workspaceInfo *workspace.Info
 	if t.workspaceManager != nil {
 		var err error
-		workspaceInfo, err = t.workspaceManager.DetectWorkspace(args)
+		workspaceInfo, err = DetectAndRegisterWorkspace(t.workspaceManager, args)
 		if err != nil {
 			return HandleWorkspaceDetectionError(err, "")
 		}