Move INITIALIZE_FUNCTION macro to goto-programs to reduce linking dependency

The INITIALIZE_FUNCTION macro was defined in
linking/static_lifetime_init.h, causing 22 files across the codebase to
include this header solely to access this string constant. This
translated to an otherwise-unnecessary dependency on the linking module.
Move the macro definition to a new header
goto-programs/initialize_function.h, which is a more fundamental module.

Co-authored-by: Kiro <[email protected]>

Author: tautschnig

src/ansi-c/ansi_c_internal_additions.cpp

@@ -12,8 +12,7 @@ Author: Daniel Kroening, [email protected]
 #include <util/config.h>
 
 #include <goto-programs/adjust_float_expressions.h>
-
-#include <linking/static_lifetime_init.h>
+#include <goto-programs/initialize_function.h>
 
 #include "ansi_c_parser.h"
 

src/ansi-c/goto-conversion/goto_convert_functions.cpp

@@ -14,8 +14,7 @@ Date: June 2003
 #include <util/symbol_table_builder.h>
 
 #include <goto-programs/goto_model.h>
-
-#include <linking/static_lifetime_init.h>
+#include <goto-programs/initialize_function.h>
 
 goto_convert_functionst::goto_convert_functionst(
   symbol_table_baset &_symbol_table,

src/cpp/cpp_internal_additions.cpp

@@ -8,16 +8,15 @@ Author: Daniel Kroening, [email protected]
 
 #include "cpp_internal_additions.h"
 
-#include <ostream>
-
 #include <util/c_types.h>
 #include <util/config.h>
 
-#include <ansi-c/ansi_c_internal_additions.h>
+#include <goto-programs/adjust_float_expressions.h>
+#include <goto-programs/initialize_function.h>
 
-#include <linking/static_lifetime_init.h>
+#include <ansi-c/ansi_c_internal_additions.h>
 
-#include <goto-programs/adjust_float_expressions.h>
+#include <ostream>
 
 std::string c2cpp(const std::string &s)
 {

src/goto-cc/compile.cpp

@@ -23,6 +23,7 @@ Date: June 2006
 #include <util/unicode.h>
 #include <util/version.h>
 
+#include <goto-programs/initialize_function.h>
 #include <goto-programs/name_mangler.h>
 #include <goto-programs/read_goto_binary.h>
 #include <goto-programs/write_goto_binary.h>
@@ -34,7 +35,6 @@ Date: June 2006
 #include <langapi/language_file.h>
 #include <langapi/mode.h>
 #include <linking/linking.h>
-#include <linking/static_lifetime_init.h>
 
 #include <cstring>
 #include <filesystem>

src/goto-checker/module_dependencies.txt

@@ -3,6 +3,5 @@ goto-checker
 goto-programs
 goto-symex
 langapi
-linking
 solvers
 util

src/goto-checker/symex_bmc.cpp

@@ -14,10 +14,9 @@ Author: Daniel Kroening, [email protected]
 #include <util/simplify_expr.h>
 #include <util/source_location.h>
 
+#include <goto-programs/initialize_function.h>
 #include <goto-programs/unwindset.h>
 
-#include <linking/static_lifetime_init.h>
-
 #include <limits>
 
 symex_bmct::symex_bmct(

src/goto-checker/symex_coverage.cpp

@@ -19,9 +19,9 @@ Date: March 2016
 #include <util/xml.h>
 
 #include <goto-programs/goto_functions.h>
+#include <goto-programs/initialize_function.h>
 
 #include <langapi/language_util.h>
-#include <linking/static_lifetime_init.h>
 
 #include <chrono> // IWYU pragma: keep
 #include <ctime>  // IWYU pragma: keep - For std::time_t

src/goto-instrument/aggressive_slicer.cpp

@@ -14,10 +14,9 @@ Author: Elizabeth Polgreen, [email protected]
 #include <util/message.h>
 
 #include <goto-programs/goto_model.h>
+#include <goto-programs/initialize_function.h>
 #include <goto-programs/show_properties.h>
 
-#include <linking/static_lifetime_init.h>
-
 #include <analyses/call_graph_helpers.h>
 
 #include "remove_function.h"

src/goto-instrument/call_sequences.cpp

@@ -13,16 +13,15 @@ Date: April 2013
 
 #include "call_sequences.h"
 
-#include <stack>
-#include <iostream>
-
 #include <util/simplify_expr.h>
 
 #include <goto-programs/goto_model.h>
+#include <goto-programs/initialize_function.h>
 
 #include <langapi/language_util.h>
 
-#include <linking/static_lifetime_init.h>
+#include <iostream>
+#include <stack>
 
 void show_call_sequences(
   const irep_idt &caller,

src/goto-instrument/contracts/dynamic-frames/dfcc_library.cpp

@@ -20,6 +20,7 @@ Author: Remi Delmas, [email protected]
 
 #include <goto-programs/goto_function.h>
 #include <goto-programs/goto_model.h>
+#include <goto-programs/initialize_function.h>
 #include <goto-programs/unwindset.h>
 
 #include <ansi-c/c_expr.h>
@@ -28,7 +29,6 @@ Author: Remi Delmas, [email protected]
 #include <ansi-c/goto-conversion/goto_convert_functions.h>
 #include <goto-instrument/generate_function_bodies.h>
 #include <goto-instrument/unwind.h>
-#include <linking/static_lifetime_init.h>
 
 #include "dfcc_utils.h"