-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Closed
Description
We used deno bundle in its original implementation, then with its removal migrated to a custom build script with esbuild
Now that deno bundle is back we wanted to migrate back to using it, but one thing we are missing right now to recreate our current esbuild config is the keepNames option.
I tried adding a --keep-names flag to deno bundle and this does what it should do, but before submitting a PR I would like to discuss the best way forward.
- Would you appreciate a PR adding the
--keep-namesflag todeno bundleor is this a requirement too specific to be added as its own flag? - If you agree to have this added, should we just add the
--keep-namesflag todeno bundleand useEsbuildFlagsBuilder.raw_flag()internally? Or should we addEsbuildFlagsBuilder.keep_names()to https://github.com/denoland/esbuild_client/blob/main/src/flags.rs ? - Considering that there are more valid
esbuildflags currently not supported bydeno bundle, should we add a--raw-esbuild-optionsflag todeno bundleinstead of adding individualesbuildflags everytime someone comes up with the requirement?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels