v2.1.14 (#30863)

Author: bartlomieju

Cargo.lock

@@ -6,6 +6,12 @@ https://github.com/denoland/deno/releases
 We also have one-line install commands at:
 https://github.com/denoland/deno_install
 
+### 2.1.14 / 2025.05.13
+
+- fix(ext/node): set default callback for `fs.close` (#30720)
+- fix(ext/node): validate `fs.close` callback function (#30679)
+- fix: reject running `.bat` and `.cmd` directly on windows (#30818)
+
 ### 2.1.13 / 2025.05.13
 
 - fix: handling of contradictory global permission flags (#29213)

Releases.md

@@ -2,7 +2,7 @@
 
 [package]
 name = "deno"
-version = "2.1.13"
+version = "2.1.14"
 authors.workspace = true
 default-run = "deno"
 edition.workspace = true

cli/Cargo.toml

@@ -1 +1 @@
-2.1.13
+2.1.14

cli/lib/version.txt

@@ -2,7 +2,7 @@
 
 [package]
 name = "denort"
-version = "2.1.13"
+version = "2.1.14"
 authors.workspace = true
 default-run = "denort"
 edition.workspace = true

cli/rt/Cargo.toml

@@ -1,22 +1,41 @@
 // Copyright 2018-2025 the Deno authors. MIT license.
 
-// TODO(petamoriken): enable prefer-primordials for node polyfills
-// deno-lint-ignore-file prefer-primordials
-
-import type { CallbackWithError } from "ext:deno_node/_fs/_fs_common.ts";
+import {
+  type CallbackWithError,
+  makeCallback,
+} from "ext:deno_node/_fs/_fs_common.ts";
 import { getValidatedFd } from "ext:deno_node/internal/fs/utils.mjs";
-import { core } from "ext:core/mod.js";
+import { core, primordials } from "ext:core/mod.js";
+
+const {
+  Error,
+  ErrorPrototype,
+  ObjectPrototypeIsPrototypeOf,
+} = primordials;
 
-export function close(fd: number, callback: CallbackWithError) {
+function defaultCloseCallback(err: Error | null) {
+  if (err !== null) throw err;
+}
+
+export function close(
+  fd: number,
+  callback: CallbackWithError = defaultCloseCallback,
+) {
   fd = getValidatedFd(fd);
+  if (callback !== defaultCloseCallback) {
+    callback = makeCallback(callback);
+  }
+
   setTimeout(() => {
     let error = null;
     try {
       // TODO(@littledivy): Treat `fd` as real file descriptor. `rid` is an
       // implementation detail and may change.
       core.close(fd);
     } catch (err) {
-      error = err instanceof Error ? err : new Error("[non-error thrown]");
+      error = ObjectPrototypeIsPrototypeOf(ErrorPrototype, err)
+        ? err as Error
+        : new Error("[non-error thrown]");
     }
     callback(error);
   }, 0);

ext/node/polyfills/_fs/_fs_close.ts

@@ -690,6 +690,20 @@ fn compute_run_cmd_and_check_permissions(
       command: arg_cmd.to_string(),
       error: Box::new(e),
     })?;
+  if let Some(ext) = cmd.extension() {
+    if cfg!(windows) && (ext == "bat" || ext == "cmd") {
+      return Err(ProcessError::SpawnFailed {
+        command: arg_cmd.to_string(),
+        error: Box::new(
+          std::io::Error::new(
+            std::io::ErrorKind::PermissionDenied,
+            "Use a shell to execute .bat or .cmd files",
+          )
+          .into(),
+        ),
+      });
+    }
+  }
   check_run_permission(
     state,
     &RunQueryDescriptor::Path {

ext/process/lib.rs

@@ -775,6 +775,28 @@ Deno.test(
   },
 );
 
+Deno.test(
+  {
+    permissions: { run: true, read: true, write: true },
+    ignore: Deno.build.os !== "windows",
+  },
+  async function rejectBatAndCmdFiles() {
+    const tempDir = await Deno.makeTempDir();
+    const fileName = tempDir + "/test.bat";
+    const file = await Deno.open(fileName, {
+      create: true,
+      write: true,
+    });
+
+    await assertRejects(async () => {
+      await new Deno.Command(fileName, {
+        args: ["&calc.exe"],
+      }).output();
+    }, Deno.errors.PermissionDenied);
+    file.close();
+  },
+);
+
 Deno.test(
   {
     permissions: { run: true, read: true },

tests/unit/command_test.ts

@@ -1,7 +1,7 @@
 // Copyright 2018-2025 the Deno authors. MIT license.
 import { assert, assertThrows, fail } from "@std/assert";
 import { assertCallbackErrorUncaught } from "../_test_utils.ts";
-import { close, closeSync } from "node:fs";
+import { close, closeSync, openSync } from "node:fs";
 
 Deno.test({
   name: "ASYNC: File is closed",
@@ -101,3 +101,12 @@ Deno.test({
     },
   });
 });
+
+Deno.test({
+  name: "[std/node/fs] close with default callback if none is provided",
+}, async () => {
+  const tempFile = await Deno.makeTempFile();
+  const rid = openSync(tempFile, "r");
+  close(rid);
+  await Deno.remove(tempFile);
+});