test: cover partitionValues_parsed in partitioned write tests#2467
Open
scottsand-db wants to merge 1 commit intodelta-io:mainfrom
Open
test: cover partitionValues_parsed in partitioned write tests#2467scottsand-db wants to merge 1 commit intodelta-io:mainfrom
scottsand-db wants to merge 1 commit intodelta-io:mainfrom
Conversation
f9020d2 to
94af5cb
Compare
Co-authored-by: Isaac
94af5cb to
1b9f4b9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2467 +/- ##
=======================================
Coverage 88.40% 88.40%
=======================================
Files 178 178
Lines 58235 58235
Branches 58235 58235
=======================================
Hits 51485 51485
Misses 4783 4783
Partials 1967 1967 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Update
test_write_partitioned_normal_values_roundtripandtest_write_partitioned_null_values_roundtripinwrite_partitioned.rsto also cross-test writing parsed partition values (on/off)How was this change tested?
cargo nextest run -p delta_kernel --test write_partitioned --all-features— 90 cases pass.