"Could not convert the File Changes Service to a TFS Pending Changes Service. This should never happen!"

[davidjbroadhead]

Getting the error "Could not convert the File Changes Service to a TFS Pending Changes Service" when doing a diff all for a changeset open in the team explorer window but then opening another changeset whilst the files are still iterating in another comparison tool.

[deadlydog]

To clarify, you are saying that you experience the error when you start iterating through the changeset files with Diff All Files, but then navigate to another changeset in the Team Explorer window before Diff All Files has finished iterating through all of the files in the first changeset? Is that correct @davidjbroadhead ?

[davidjbroadhead]

Yes that's right. I use winmerge and it keeps opening blank comparisons for each file remaining once navigating to another changeset

[deadlydog]

Ok, that's a use-case I had never considered or tested. I haven't touched this extension in quite a while, but will keep this in mind the next time I revisit it. It sounds like Visual Studio 2019 will be coming out later this year, so I'll probably need to update the extension to support it, and can try and add this functionality at that time. To be clear, the desired functionality is that is should simply cancel any pending diffs that haven't been opened yet when you navigate away from the changeset in Team Explorer, correct?

I'm also open to Pull Requests if you're inclined to come up with a fix yourself ;)

[davidjbroadhead]

Ok, yes I think cancelling it would be right. Thank you!