move TestConfig.post_init logic to finalize_and_validate to respect hierarchical configs (#11730) (#11738)

(cherry picked from commit 0fff576)

Co-authored-by: Michelle Ark <[email protected]>
Co-authored-by: Quigley Malcolm <[email protected]>

Author: 3 people

.changes/unreleased/Fixes-20250612-145159.yaml

@@ -0,0 +1,6 @@
+kind: Fixes
+body: Fix store_failures hierarachical config parsing
+time: 2025-06-12T14:51:59.358498-04:00
+custom:
+  Author: michelleark
+  Issue: "10165"

core/dbt/artifacts/resources/v1/config.py

@@ -181,7 +181,7 @@ class TestConfig(NodeAndTestConfig):
     warn_if: str = "!= 0"
     error_if: str = "!= 0"
 
-    def __post_init__(self):
+    def finalize_and_validate(self):
         """
         The presence of a setting for `store_failures_as` overrides any existing setting for `store_failures`,
         regardless of level of granularity. If `store_failures_as` is not set, then `store_failures` takes effect.
@@ -207,6 +207,7 @@ def __post_init__(self):
         but still allow for backwards compatibility for `store_failures`.
         See https://github.com/dbt-labs/dbt-core/issues/6914 for more information.
         """
+        super().finalize_and_validate()
 
         # if `store_failures_as` is not set, it gets set by `store_failures`
         # the settings below mimic existing behavior prior to `store_failures_as`
@@ -229,6 +230,8 @@ def __post_init__(self):
         else:
             self.store_failures = get_store_failures_map.get(self.store_failures_as, True)
 
+        return self
+
     @classmethod
     def same_contents(cls, unrendered: Dict[str, Any], other: Dict[str, Any]) -> bool:
         """This is like __eq__, except it explicitly checks certain fields."""

tests/functional/schema_tests/fixtures.py

@@ -1273,3 +1273,31 @@
     data_tests:
       - my_custom_test
 """
+
+store_failures_models__my_model_sql = """
+select 1 as id
+"""
+
+store_failures_models_true__config_yml = """
+version: 2
+models:
+  - name: my_model
+    columns:
+      - name: id
+        tests:
+          - not_null:
+              config:
+                store_failures: true
+"""
+
+store_failures_models_false__config_yml = """
+version: 2
+models:
+  - name: my_model
+    columns:
+      - name: id
+        tests:
+          - not_null:
+              config:
+                store_failures: false
+"""

tests/functional/schema_tests/test_schema_v2_tests.py

@@ -77,6 +77,9 @@
     quote_required_models__model_sql,
     quote_required_models__schema_yml,
     seeds__some_seed_csv,
+    store_failures_models__my_model_sql,
+    store_failures_models_false__config_yml,
+    store_failures_models_true__config_yml,
     test_context_macros__custom_schema_tests_sql,
     test_context_macros__my_test_sql,
     test_context_macros__test_my_datediff_sql,
@@ -1128,3 +1131,87 @@ def test_macro_resolution_test_namespace(
         # leading to the macro being missing in the TestNamespace
         run_dbt(["deps"])
         run_dbt(["parse"])
+
+
+class TestSchemaTestStoreFailuresTrueParsing:
+    @pytest.fixture(scope="class")
+    def models(self):
+        return {
+            "schema.yml": store_failures_models_true__config_yml,
+            "my_model.sql": store_failures_models__my_model_sql,
+        }
+
+    def test_parse_store_failures_True_as_table(self, project):
+        manifest = run_dbt(["parse"])
+        test_node = [
+            node for node in manifest.nodes.values() if "not_null_my_model_id" in node.fqn
+        ][0]
+
+        assert test_node.config.store_failures
+        assert test_node.config.store_failures_as == "table"
+
+
+class TestSchemaTestStoreFailuresFalseParsing:
+    @pytest.fixture(scope="class")
+    def models(self):
+        return {
+            "schema.yml": store_failures_models_false__config_yml,
+            "my_model.sql": store_failures_models__my_model_sql,
+        }
+
+    def test_parse_store_failures_False_as_ephemeral(self, project):
+        manifest = run_dbt(["parse"])
+        test_node = [
+            node for node in manifest.nodes.values() if "not_null_my_model_id" in node.fqn
+        ][0]
+
+        assert not test_node.config.store_failures
+        assert test_node.config.store_failures_as == "ephemeral"
+
+
+class TestSchemaTestStoreFailuresTrueHierarchicalParsing:
+    @pytest.fixture(scope="class")
+    def models(self):
+        return {
+            "schema.yml": store_failures_models_true__config_yml,
+            "my_model.sql": store_failures_models__my_model_sql,
+        }
+
+    @pytest.fixture(scope="class")
+    def project_config_update(self):
+        return {
+            "tests": {"+store_failures": False},
+        }
+
+    def test_parse_store_failures_True_as_table(self, project):
+        manifest = run_dbt(["parse"])
+        test_node = [
+            node for node in manifest.nodes.values() if "not_null_my_model_id" in node.fqn
+        ][0]
+
+        assert test_node.config.store_failures
+        assert test_node.config.store_failures_as == "table"
+
+
+class TestSchemaTestStoreFailuresFalseHierarchicalParsing:
+    @pytest.fixture(scope="class")
+    def models(self):
+        return {
+            "schema.yml": store_failures_models_false__config_yml,
+            "my_model.sql": store_failures_models__my_model_sql,
+        }
+
+    @pytest.fixture(scope="class")
+    def project_config_update(self):
+        return {
+            "tests": {"+store_failures": True},
+        }
+
+    def test_parse_store_failures_False_as_ephemeral(self, project):
+        manifest = run_dbt(["parse"])
+        test_node = [
+            node for node in manifest.nodes.values() if "not_null_my_model_id" in node.fqn
+        ][0]
+
+        assert not test_node.config.store_failures
+        assert test_node.config.store_failures_as == "ephemeral"