Skip to content

Conversation

@mfranzke
Copy link
Collaborator

@mfranzke mfranzke commented Dec 8, 2025

Proposed changes

Removed redundant build output command for stencil components. Or is there any reason I don't see, @nmerget ?

Types of changes

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improvements to existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

🔭🐙🐈 Test this branch here: https://design-system.deutschebahn.com/core-web/review/refactor-remove-redundant-build-command-for-stencil-components

Removed build output command for stencil components.
@changeset-bot
Copy link

changeset-bot bot commented Dec 8, 2025

⚠️ No Changeset found

Latest commit: 32f79c6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mfranzke mfranzke moved this from 🏗 In progress to 🎁 Ready for review in UX Engineering Team Backlog Dec 8, 2025
@mfranzke mfranzke moved this from 🎁 Ready for review to 👀 Actively In Review in UX Engineering Team Backlog Dec 8, 2025
@mfranzke mfranzke added the 🍄🆙improvement New feature or request label Dec 8, 2025
@mfranzke mfranzke enabled auto-merge (squash) December 8, 2025 08:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes a duplicate build script that was redundantly building the same stencil/web components workspace twice during the build-outputs phase.

Key Changes:

  • Removed build-outputs:stencil-components script entry which was a duplicate of the existing build-outputs:wc-core-components script

@nmerget
Copy link
Collaborator

nmerget commented Dec 8, 2025

Should be the same as line 27, I guess it is a leftover

@mfranzke mfranzke disabled auto-merge December 8, 2025 09:54
@mfranzke mfranzke merged commit 4acf4f7 into main Dec 8, 2025
79 checks passed
@mfranzke mfranzke deleted the refactor-remove-redundant-build-command-for-stencil-components branch December 8, 2025 09:54
@github-project-automation github-project-automation bot moved this from 👀 Actively In Review to ✅ Done in UX Engineering Team Backlog Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🍄🆙improvement New feature or request

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants