Skip to content

Commit 8e522eb

Browse files
authored
fix: checks-done step must succeed (#261)
1 parent a2309c6 commit 8e522eb

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

.github/workflows/default.yml

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,20 @@ jobs:
2929
needs: [init]
3030

3131
checks-done:
32+
if: ${{ always() }}
3233
runs-on: ubuntu-latest
3334
steps:
3435
- name: 🎉 Checks done
35-
run: echo "🎉 Linting & build were successful."
36+
run: |
37+
resultBuild="${{ needs.build.result }}"
38+
resultLint="${{ needs.lint.result }}"
39+
if [[ $resultBuild == "success" && $resultLint == "success" ]]; then
40+
echo "🎉 Linting & build were successful."
41+
exit 0
42+
else
43+
echo "There have been problems with the Cypress tests."
44+
exit 1
45+
fi
3646
needs: [build, lint]
3747

3848
deploy:

0 commit comments

Comments
 (0)