Skip to content
This repository was archived by the owner on Nov 20, 2021. It is now read-only.

Commit e42ec90

Browse files
Kyle TravisChrisRx
authored andcommitted
Fix apiGroup for manager-role rule
1 parent a7f0409 commit e42ec90

File tree

4 files changed

+48
-11
lines changed

4 files changed

+48
-11
lines changed

config/crd/bases/infrastructure.crit.sh_dockerinfrastructureproviders.yaml

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,26 +29,33 @@ spec:
2929
status: {}
3030
validation:
3131
openAPIV3Schema:
32-
description: DockerInfrastructureProvider is the Schema for the infrastructureproviders API
32+
description: DockerInfrastructureProvider is the Schema for the infrastructureproviders
33+
API
3334
properties:
3435
apiVersion:
35-
description: 'APIVersion defines the versioned schema of this representation of an object. Servers should convert recognized schemas to the latest internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
36+
description: 'APIVersion defines the versioned schema of this representation
37+
of an object. Servers should convert recognized schemas to the latest
38+
internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
3639
type: string
3740
kind:
38-
description: 'Kind is a string value representing the REST resource this object represents. Servers may infer this from the endpoint the client submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
41+
description: 'Kind is a string value representing the REST resource this
42+
object represents. Servers may infer this from the endpoint the client
43+
submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
3944
type: string
4045
metadata:
4146
type: object
4247
spec:
43-
description: DockerInfrastructureProviderSpec defines the desired state of DockerInfrastructureProvider
48+
description: DockerInfrastructureProviderSpec defines the desired state
49+
of DockerInfrastructureProvider
4450
properties:
4551
defaultImage:
4652
type: string
4753
required:
4854
- defaultImage
4955
type: object
5056
status:
51-
description: InfrastructureProviderStatus defines the observed state of DockerInfrastructureProvider
57+
description: InfrastructureProviderStatus defines the observed state of
58+
DockerInfrastructureProvider
5259
properties:
5360
lastUpdated:
5461
format: date-time

config/crd/bases/infrastructure.crit.sh_dockermachines.yaml

Lines changed: 32 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,14 @@ spec:
2424
description: DockerMachine is the Schema for the dockermachines API
2525
properties:
2626
apiVersion:
27-
description: 'APIVersion defines the versioned schema of this representation of an object. Servers should convert recognized schemas to the latest internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
27+
description: 'APIVersion defines the versioned schema of this representation
28+
of an object. Servers should convert recognized schemas to the latest
29+
internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
2830
type: string
2931
kind:
30-
description: 'Kind is a string value representing the REST resource this object represents. Servers may infer this from the endpoint the client submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
32+
description: 'Kind is a string value representing the REST resource this
33+
object represents. Servers may infer this from the endpoint the client
34+
submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
3135
type: string
3236
metadata:
3337
type: object
@@ -51,10 +55,34 @@ spec:
5155
description: DockerMachineStatus defines the observed state of DockerMachine
5256
properties:
5357
failureMessage:
54-
description: "FailureMessage will be set in the event that there is a terminal problem reconciling the Machine and will contain a more verbose string suitable for logging and human consumption. \n This field should not be set for transitive errors that a controller faces that are expected to be fixed automatically over time (like service outages), but instead indicate that something is fundamentally wrong with the Machine's spec or the configuration of the controller, and that manual intervention is required. Examples of terminal errors would be invalid combinations of settings in the spec, values that are unsupported by the controller, or the responsible controller itself being critically misconfigured. \n Any transient errors that occur during the reconciliation of Machines can be added as events to the Machine object and/or logged in the controller's output."
58+
description: "FailureMessage will be set in the event that there is
59+
a terminal problem reconciling the Machine and will contain a more
60+
verbose string suitable for logging and human consumption. \n This
61+
field should not be set for transitive errors that a controller faces
62+
that are expected to be fixed automatically over time (like service
63+
outages), but instead indicate that something is fundamentally wrong
64+
with the Machine's spec or the configuration of the controller, and
65+
that manual intervention is required. Examples of terminal errors
66+
would be invalid combinations of settings in the spec, values that
67+
are unsupported by the controller, or the responsible controller itself
68+
being critically misconfigured. \n Any transient errors that occur
69+
during the reconciliation of Machines can be added as events to the
70+
Machine object and/or logged in the controller's output."
5571
type: string
5672
failureReason:
57-
description: "FailureReason will be set in the event that there is a terminal problem reconciling the Machine and will contain a succinct value suitable for machine interpretation. \n This field should not be set for transitive errors that a controller faces that are expected to be fixed automatically over time (like service outages), but instead indicate that something is fundamentally wrong with the Machine's spec or the configuration of the controller, and that manual intervention is required. Examples of terminal errors would be invalid combinations of settings in the spec, values that are unsupported by the controller, or the responsible controller itself being critically misconfigured. \n Any transient errors that occur during the reconciliation of Machines can be added as events to the Machine object and/or logged in the controller's output."
73+
description: "FailureReason will be set in the event that there is a
74+
terminal problem reconciling the Machine and will contain a succinct
75+
value suitable for machine interpretation. \n This field should not
76+
be set for transitive errors that a controller faces that are expected
77+
to be fixed automatically over time (like service outages), but instead
78+
indicate that something is fundamentally wrong with the Machine's
79+
spec or the configuration of the controller, and that manual intervention
80+
is required. Examples of terminal errors would be invalid combinations
81+
of settings in the spec, values that are unsupported by the controller,
82+
or the responsible controller itself being critically misconfigured.
83+
\n Any transient errors that occur during the reconciliation of Machines
84+
can be added as events to the Machine object and/or logged in the
85+
controller's output."
5886
type: string
5987
ready:
6088
type: boolean

config/rbac/role.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,9 @@ metadata:
66
creationTimestamp: null
77
name: manager-role
88
rules:
9-
- resources:
9+
- apiGroups:
10+
- ""
11+
resources:
1012
- secrets
1113
verbs:
1214
- '*'

controllers/dockerinfrastructureprovider_controller.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ func (r *DockerInfrastructureProviderReconciler) SetupWithManager(mgr ctrl.Manag
5959
// +kubebuilder:rbac:groups=infrastructure.crit.sh,resources=dockerinfrastructureproviders,verbs=get;list;watch
6060
// +kubebuilder:rbac:groups=infrastructure.crit.sh,resources=dockerinfrastructureproviders/status,verbs=create;update
6161
// +kubebuilder:rbac:groups=machine.crit.sh,resources=infrastructureproviders;infrastructureproviders/status,verbs=get;list;watch
62-
// +kubebuilder:rbac:groups=,resources=secrets,verbs=*
62+
// +kubebuilder:rbac:groups="",resources=secrets,verbs=*
6363

6464
func (r *DockerInfrastructureProviderReconciler) Reconcile(req ctrl.Request) (_ ctrl.Result, reterr error) {
6565
ctx := context.Background()

0 commit comments

Comments
 (0)