fix: helmet.hpp: pimpl implementation fixes.

Signed-off-by: Amlal El Mahrouss <[email protected]>

Author: amlel-el-mahrouss

include/boost/http_proto/server/helmet.hpp

@@ -41,8 +41,8 @@ struct helmet_options
 class helmet
 {
     struct impl;
-    std::unique_ptr<impl> impl_;
-    
+    impl* impl_;
+
 public:
     /**
     @brief Builds an helmet and compute its options for caching purposes.
@@ -54,6 +54,9 @@ class helmet
     BOOST_HTTP_PROTO_DECL
     ~helmet();
 
+    helmet& operator=(helmet&&) noexcept;
+    helmet(helmet&&) noexcept;
+
     /**
         @brief Iterates over cachedHeaders and apply its rules to the response params.
         @param p route parameter argument

src/server/helmet.cpp

@@ -81,8 +81,8 @@ struct helmet::impl
 helmet::
 helmet(
     helmet_options helmet_options)
+    : impl_(new impl())
 {
-    impl_ = std::make_unique<impl>();
     impl_->options_ = std::move(helmet_options);
 
     std::for_each(impl_->options_.headers.begin(), impl_->options_.headers.end(), 
@@ -93,10 +93,27 @@ helmet(
     });
 }
 
-/**
-    AMLALE: This is here to prevent compiler erros from unique_ptr. (destructor doesnn't know how to destroy impl)
-*/
-helmet::~helmet() = default;
+helmet::~helmet()
+{
+    delete impl_;
+    impl_ = nullptr;
+}
+
+helmet& helmet::operator=(helmet&& other) noexcept
+{
+    impl_ = other.impl_;
+    other.impl_ = nullptr;
+
+    return *this;
+}
+
+
+helmet::
+helmet(helmet&& other) noexcept
+    : impl_(other.impl_)
+{
+    other.impl_ = nullptr;
+}
 
 route_result
 helmet::