Code: upgrade deps, codesniffer fixes (#39)

Author: petrparolek

Makefile

@@ -18,7 +18,7 @@ csf: vendor
 	vendor/bin/codefixer src tests
 
 phpstan: vendor
-	vendor/bin/phpstan analyse -l max -c phpstan.neon src
+	vendor/bin/phpstan analyse -l 8 -c phpstan.neon src
 
 tests: vendor
 	vendor/bin/tester -s -p php --colors 1 -C tests/cases

composer.json

@@ -22,16 +22,15 @@
     "nette/application": "^3.0.0"
   },
   "require-dev": {
-    "nette/http": "~2.4.8 || ~3.0.0",
+    "nette/http": "~2.4.8 || ^3.0.0",
     "ninjify/nunjuck": "^0.3.0",
-    "ninjify/qa": "^0.9.0",
-    "phpstan/extension-installer": "^1.0",
-    "phpstan/phpstan-deprecation-rules": "^0.11.0",
-    "phpstan/phpstan-nette": "^0.11.1",
-    "phpstan/phpstan-shim": "^0.11.2",
-    "phpstan/phpstan-strict-rules": "^0.11.0",
+    "ninjify/qa": "^0.13.0",
+    "phpstan/phpstan": "^1.0",
+    "phpstan/phpstan-deprecation-rules": "^1.0",
+    "phpstan/phpstan-nette": "^1.0",
+    "phpstan/phpstan-strict-rules": "^1.0",
     "psr/http-message": "~1.0.1",
-    "tracy/tracy": "~2.6.1"
+    "tracy/tracy": "~2.9.1"
   },
   "autoload": {
     "psr-4": {
@@ -46,7 +45,10 @@
   "minimum-stability": "dev",
   "prefer-stable": true,
   "config": {
-    "sort-packages": true
+    "sort-packages": true,
+    "allow-plugins": {
+      "dealerdirect/phpcodesniffer-composer-installer": true
+    }
   },
   "extra": {
     "branch-alias": {

phpstan.neon

@@ -1,3 +1,10 @@
+includes:
+	#- vendor/phpstan/phpstan-deprecation-rules/rules.neon
+	- vendor/phpstan/phpstan-nette/extension.neon
+	- vendor/phpstan/phpstan-nette/rules.neon
+	- vendor/phpstan/phpstan-strict-rules/rules.neon
+
 parameters:
 	ignoreErrors:
 		- '#^Property Contributte\\Application\\Response\\Fly\\Buffer\\(FileBuffer|ProcessBuffer)\:\:\$pointer \(resource\) does not accept resource\|false\.$#'
+		- '#^Property Contributte\\Application\\Response\\Fly\\Buffer\\(.*)Buffer\:\:\$pointer \(resource\) in isset\(\) is not nullable\.$#'

ruleset.xml

@@ -4,6 +4,7 @@
 	<rule ref="./vendor/ninjify/coding-standard/contributte.xml">
 		<exclude name="SlevomatCodingStandard.ControlStructures.RequireTernaryOperator.TernaryOperatorNotUsed" />
 		<exclude name="SlevomatCodingStandard.PHP.TypeCast" />
+		<exclude name="SlevomatCodingStandard.Commenting.InlineDocCommentDeclaration.MissingVariable" />
 	</rule>
 
 	<!-- Specific rules -->

src/Response/CSVResponse.php

@@ -110,8 +110,10 @@ private function getBom(): string
 		switch (strtolower($this->outputEncoding)) {
 			case 'utf-8':
 				return b"\xEF\xBB\xBF";
+
 			case 'utf-16':
 				return b"\xFF\xFE";
+
 			default:
 				return '';
 		}

src/Response/Fly/Buffer/FileBuffer.php

@@ -36,6 +36,7 @@ public function write($data): void
 	 */
 	public function read(int $size)
 	{
+		/** @var positive-int $size */
 		return fread($this->pointer, $size);
 	}
 

src/Response/Fly/Buffer/ProcessBuffer.php

@@ -36,6 +36,7 @@ public function write($data): void
 	 */
 	public function read(int $size)
 	{
+		/** @var positive-int $size */
 		return fread($this->pointer, $size);
 	}
 

src/Response/JsonPrettyResponse.php

@@ -28,7 +28,7 @@ class JsonPrettyResponse implements IResponse
 	public function __construct($payload, ?string $contentType = null)
 	{
 		$this->payload = $payload;
-		$this->contentType = $contentType ?: 'application/json';
+		$this->contentType = $contentType ?? 'application/json';
 	}
 
 	public function setCode(int $code): void

src/Response/PSR7StreamResponse.php

@@ -25,13 +25,13 @@ final class PSR7StreamResponse implements IResponse
 	/**
 	 * @param StreamInterface $stream PSR7   Stream instance
 	 * @param string $name Imposed file name
-	 * @param string $contentType MIME content type
+	 * @param ?string $contentType MIME content type
 	 */
 	public function __construct(StreamInterface $stream, string $name, ?string $contentType = null)
 	{
 		$this->stream = $stream;
 		$this->name = $name;
-		$this->contentType = $contentType ?: 'application/octet-stream';
+		$this->contentType = $contentType ?? 'application/octet-stream';
 	}
 
 	/**