-
Notifications
You must be signed in to change notification settings - Fork 9
Expand file tree
/
Copy pathconcurrency-Queue-test.js
More file actions
646 lines (597 loc) · 20.1 KB
/
concurrency-Queue-test.js
File metadata and controls
646 lines (597 loc) · 20.1 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
import Axios from 'axios'
import sinon from 'sinon'
import { expect } from 'chai'
import http from 'http'
import { describe, it, before, beforeEach, after } from 'mocha'
import MockAdapter from 'axios-mock-adapter'
import { ConcurrencyQueue } from '../../lib/core/concurrency-queue'
import FormData from 'form-data'
import { createReadStream } from 'fs'
import path from 'path'
import multiparty from 'multiparty'
import { client } from '../../lib/contentstack'
const axios = Axios.create()
let server
var host = 'http://localhost'
var port = 4444
const api = Axios.create({
baseURL: `${host}:${port}`
})
let concurrencyQueue = new ConcurrencyQueue({ axios: api })
const logHandlerStub = sinon.stub()
const retryConditionStub = sinon.stub()
const retryDelayOptionsStub = sinon.stub()
const wrapPromise = (p, count) => {
return p.then(
result => ({ result, success: true }),
result => ({ result, success: false })
)
}
const wrapPromiseInArray = (p, count) => {
const array = []
for (let i = 0; i < count; i++) {
array.push(p.then(
result => ({ result, success: true }),
result => ({ result, success: false })
))
}
return array
}
const sequence = (count) => {
const array = []
for (let i = 0; i < count; i++) {
array.push(i)
}
return array
}
const reconfigureQueue = (options = {}) => {
const config = Object.assign({
retryOnError: true,
logHandler: logHandlerStub,
retryCondition: () => {
return true
}
}, options)
concurrencyQueue.detach()
concurrencyQueue = new ConcurrencyQueue({ axios: api, config })
}
var returnContent = false
var unauthorized = false
var token = 'Bearer <token_value_new>'
describe('Concurrency queue test', () => {
before(() => {
server = http.createServer((req, res) => {
if (req.url === '/user-session') {
res.writeHead(200, { 'Content-Type': 'application/json' })
res.end(JSON.stringify({ token }))
// Test for refresh token error - uncomment this
// res.writeHead(401, { 'Content-Type': 'application/json' })
// res.end(JSON.stringify({ errorCode: 401 }))
} else if (req.url === '/unauthorized') {
if (req.headers.authorization === token) {
res.writeHead(200, { 'Content-Type': 'application/json' })
res.end(JSON.stringify({ randomInteger: 123 }))
} else {
res.writeHead(401, { 'Content-Type': 'application/json' })
res.end(JSON.stringify({ errorCode: 401 }))
}
unauthorized = !unauthorized
} else if (req.url === '/timeout') {
setTimeout(function () {
res.writeHead(400, { 'Content-Type': 'application/json' })
res.end()
}, 1000)
} else if (req.url === '/fail') {
res.writeHead(400, { 'Content-Type': 'application/json' })
return res.end(JSON.stringify({ errorCode: 400 }))
} else if (req.url === '/ratelimit') {
res.writeHead(429, { 'Content-Type': 'application/json' })
res.end(JSON.stringify({ errorCode: 429 }))
} else if (req.url === '/assetUpload') {
var form = new multiparty.Form()
form.parse(req, function (err, fields, files) {
if (err) {
return
}
if (returnContent) {
res.writeHead(200, { 'Content-Type': 'application/json' })
res.end(JSON.stringify({ randomInteger: 123 }))
} else {
res.writeHead(429, { 'Content-Type': 'application/json' })
res.end(JSON.stringify({ errorCode: 429 }))
}
returnContent = !returnContent
})
} else {
res.writeHead(200, { 'Content-Type': 'application/json' })
res.end(JSON.stringify({ randomInteger: 123 }))
}
}).listen(port, function () {
})
})
beforeEach(() => {
logHandlerStub.resetHistory()
retryDelayOptionsStub.resetHistory()
retryConditionStub.resetHistory()
})
after(() => {
if (server) {
server.close()
server = null
}
})
it('Refresh Token on 401 with 1000 concurrent request', done => {
const axios2 = client({
baseURL: `${host}:${port}`
})
const axios = client({
baseURL: `${host}:${port}`,
authorization: 'Bearer <token_value>',
logHandler: logHandlerStub,
refreshToken: () => {
return new Promise((resolve, reject) => {
return axios2.login().then((res) => {
resolve({ authorization: res.token })
}).catch((error) => {
reject(error)
})
})
}
})
Promise.all(sequence(1003).map(() => axios.axiosInstance.get('/unauthorized')))
.then((responses) => {
return responses.map(r => r.config.headers.authorization)
})
.then(objects => {
objects.forEach((authorization) => {
expect(authorization).to.be.equal(token)
})
expect(logHandlerStub.callCount).to.be.equal(5)
expect(objects.length).to.be.equal(1003)
done()
})
.catch(done)
})
it('should give passed error message when refreshToken function fails', done => {
const axios = client({
baseURL: `${host}:${port}`,
authorization: 'Bearer <token_value>',
logHandler: logHandlerStub,
refreshToken: () => {
return new Promise((resolve, reject) => {
reject(new Error('Rejected in Promise'))
})
}
})
Promise.all(sequence(3).map(() => axios.axiosInstance.get('/unauthorized')))
.catch(err => {
expect(err.errorCode).to.equal('401')
expect(err.errorMessage).to.equal('Rejected in Promise')
expect(err.message).to.equal('Unable to refresh token')
done()
})
})
it('Initialize with bad axios instance', done => {
try {
// eslint-disable-next-line no-new
new ConcurrencyQueue({ axios: undefined })
expect.fail('Undefined axios should fail')
} catch (error) {
expect(error.message).to.be.equal('HTTP client is required. Initialize the HTTP client and try again.')
done()
}
})
it('Initialization with default config test', done => {
const queue = makeConcurrencyQueue()
expect(queue.config.maxRequests).to.be.equal(5)
expect(queue.config.retryLimit).to.be.equal(5)
expect(queue.config.retryDelay).to.be.equal(300)
expect(queue.queue.length).to.be.equal(0)
expect(queue.running.length).to.be.equal(0)
expect(queue.interceptors.request).to.be.equal(0)
expect(queue.interceptors.response).to.be.equal(0)
done()
})
it('Initialization with custom config test', done => {
const queue = makeConcurrencyQueue({ maxRequests: 20, retryLimit: 2, retryDelay: 1000 })
expect(queue.config.maxRequests).to.be.equal(20)
expect(queue.config.retryLimit).to.be.equal(2)
expect(queue.config.retryDelay).to.be.equal(1000)
expect(queue.queue.length).to.be.equal(0)
expect(queue.running.length).to.be.equal(0)
done()
})
it('Detach interceptors test', done => {
const queue = makeConcurrencyQueue({ maxRequests: 20 })
queue.detach()
expect(queue.config.maxRequests).to.be.equal(20)
expect(queue.config.retryLimit).to.be.equal(5)
expect(queue.config.retryDelay).to.be.equal(300)
expect(queue.interceptors.request).to.be.equal(null)
expect(queue.interceptors.response).to.be.equal(null)
done()
})
it('Initialization with custom config negative value test', done => {
try {
makeConcurrencyQueue({ maxRequests: -10 })
expect.fail('Negative concurrency queue should fail')
} catch (error) {
expect(error.message).to.be.equal('Concurrency Manager Error: Minimum concurrent requests must be at least 1.')
done()
}
})
it('Initialization with custom config retry limit negative value test', done => {
try {
makeConcurrencyQueue({ retryLimit: -10 })
expect.fail('Negative retry limit should fail')
} catch (error) {
expect(error.message).to.be.equal('Retry Policy Error: Minimum retry limit must be at least 1.')
done()
}
})
it('Initialization with custom config retry delay value test', done => {
try {
makeConcurrencyQueue({ retryDelay: 10 })
expect.fail('Retry delay should be min 300ms')
} catch (error) {
expect(error.message).to.be.equal('Retry Policy Error: Minimum retry delay must be at least 300ms.')
done()
}
})
it('Concurrency with 100 passing requests Queue tests', done => {
Promise.all(sequence(100).map(() => api.get('/testReq')))
.then((responses) => {
return responses.map(r => r.data)
})
.then(objects => {
expect(objects.length).to.be.equal(100)
done()
})
.catch(done)
})
it('Concurrency with 100 failing requests retry on error false tests', done => {
Promise.all(sequence(100).map(() => wrapPromise(api.get('/fail'))))
.then((responses) => {
return responses.map(r => r.data)
})
.then(objects => {
expect(objects.length).to.be.equal(100)
done()
})
.catch(done)
})
it('Concurrency with 10 timeout requests', done => {
const client = Axios.create({
baseURL: `${host}:${port}`,
timeout: 250
})
const concurrency = new ConcurrencyQueue({
axios: client,
config: {
retryOnError: false,
timeout: 250,
retryOnNetworkFailure: false,
maxNetworkRetries: 0
}
})
client.get('/timeout').then(function (res) {
concurrency.detach()
expect.fail('Should not succeed')
done()
}).catch(function (err) {
concurrency.detach()
// Handle both response and non-response timeout errors
if (err.response) {
expect(err.response.status).to.be.equal(408)
expect(err.response.statusText).to.be.equal('timeout of 250ms exceeded')
} else if (err.code === 'ECONNABORTED') {
// Direct timeout without response object
expect(err.code).to.be.equal('ECONNABORTED')
expect(err.message).to.include('timeout')
} else {
expect.fail(`Unexpected error: ${err.message}`)
}
done()
}).catch(done)
})
it('Concurrency with 10 timeout requests retry', done => {
retryDelayOptionsStub.returns(100)
const client = Axios.create({
baseURL: `${host}:${port}`,
timeout: 250
})
const concurrency = new ConcurrencyQueue({
axios: client,
config: {
retryCondition: (error) => {
if (error.response && error.response.status === 408) {
return true
}
return false
},
logHandler: logHandlerStub,
retryDelayOptions: {
base: retryDelayOptionsStub()
},
retryLimit: 2,
retryOnError: true,
timeout: 250,
retryOnNetworkFailure: false,
maxNetworkRetries: 0
}
})
client.get('/timeout').then(function (res) {
concurrency.detach()
expect.fail('Should not succeed')
done()
}).catch(function (err) {
concurrency.detach()
expect(err.response.status).to.be.equal(408)
expect(err.response.statusText).to.be.equal('timeout of 250ms exceeded')
expect(logHandlerStub.callCount).to.be.at.least(2) // Should have retry attempts
done()
}).catch(done)
})
it('Concurrency with 100 failing requests retry on error with no retry condition tests', done => {
reconfigureQueue({ retryCondition: () => false })
Promise.all(sequence(100).map(() => wrapPromise(api.get('/fail'))))
.then((responses) => {
return responses.map(r => r.data)
})
.then(objects => {
expect(logHandlerStub.callCount).to.be.equal(0)
expect(objects.length).to.be.equal(100)
done()
})
.catch(done)
})
it('Concurrency with 10 failing requests with retry tests', done => {
reconfigureQueue()
Promise.all(sequence(10).map(() => wrapPromise(api.get('/fail'))))
.then((responses) => {
return responses.map(r => r.data)
})
.then(objects => {
expect(logHandlerStub.callCount).to.be.equal(50)
expect(objects.length).to.be.equal(10)
done()
})
.catch(done)
})
it('Concurrency with 10 rate limit requests Queue tests', done => {
reconfigureQueue()
Promise.all(sequence(10).map(() => wrapPromise(api.get('/ratelimit'))))
.then((responses) => {
return responses.map(r => r.data)
})
.then(objects => {
expect(logHandlerStub.callCount).to.be.equal(50)
expect(objects.length).to.be.equal(10)
done()
})
.catch(done)
})
it('Concurrency with 10 asset upload with rate limit error', done => {
reconfigureQueue()
const fuc = (pathcontent) => {
return () => {
const formData = new FormData()
const uploadStream = createReadStream(path.join(__dirname, '../sanity-check/mock/upload.html'))
formData.append('asset[upload]', uploadStream)
return formData
}
}
Promise.all(sequence(10).map(() => wrapPromise(api.post('/assetUpload', fuc()))))
.then((responses) => {
return responses.map(r => r.data)
})
.then(objects => {
expect(logHandlerStub.callCount).to.be.equal(10)
expect(objects.length).to.be.equal(10)
done()
})
.catch(done)
})
it('Concurrency with 20 request and 1 rate limit request tests', done => {
reconfigureQueue()
Promise.all(
[
...wrapPromiseInArray(api.get('/testReq'), 5),
...wrapPromiseInArray(api.get('/ratelimit'), 1),
...wrapPromiseInArray(api.get('/testReq'), 15)
]
)
.then((responses) => {
return responses.map(r => r.data)
})
.then(objects => {
expect(logHandlerStub.callCount).to.be.equal(5)
expect(objects.length).to.be.equal(21)
done()
})
.catch(done)
})
it('Concurrency with 20 request and 1 rate limit request tests', done => {
reconfigureQueue({ retryOnError: false })
Promise.all(sequence(20).map(() => wrapPromise(api.get('/timeout'))))
.then((responses) => {
expect.fail('Should not get response')
})
.catch(done)
setTimeout(() => {
concurrencyQueue.clear()
expect(concurrencyQueue.queue.length).to.equal(0)
done()
}, 1000)
})
it('Concurrency retry on custome backoff test', done => {
reconfigureQueue({
retryCondition: retryConditionStub,
retryDelayOptions: {
customBackoff: retryDelayOptionsStub
}
})
retryConditionStub.returns(true)
retryDelayOptionsStub.onCall(0).returns(200)
retryDelayOptionsStub.onCall(1).returns(300)
retryDelayOptionsStub.onCall(2).returns(-1)
retryDelayOptionsStub.returns(200)
Promise.all(sequence(10).map(() => wrapPromise(api.get('/fail'))))
.then((responses) => {
return responses.map(r => r.data)
})
.then(objects => {
expect(logHandlerStub.callCount).to.be.equal(45)
expect(objects.length).to.be.equal(10)
done()
})
.catch(done)
})
it('Concurrency retry delay with base request test', done => {
retryConditionStub.returns(true)
retryDelayOptionsStub.returns(200)
reconfigureQueue({
retryCondition: retryConditionStub,
retryDelayOptions: {
base: retryDelayOptionsStub()
}
})
Promise.all(sequence(10).map(() => wrapPromise(api.get('/fail'))))
.then((responses) => {
return responses.map(r => r.data)
})
.then(objects => {
expect(logHandlerStub.callCount).to.be.equal(50)
expect(objects.length).to.be.equal(10)
done()
})
.catch(done)
})
it('Concurrency update authorization to not pass authtoken', done => {
api.get('/fail', { headers: { authorization: 'authorization' } })
.then((response) => {
expect(response).to.equal(undefined)
done()
})
.catch((error) => {
expect(error.config.headers.authtoken).to.equal(undefined)
expect(error.config.headers.authorization).to.equal('authorization')
done()
})
.catch(done)
})
it('Request to fail with no response', done => {
reconfigureQueue()
const mock = new MockAdapter(api)
mock.onGet('/netError').networkError()
api.get('/netError')
.then((response) => {
expect(response).to.equal(undefined)
done()
})
.catch((error) => {
expect(error.esponse).to.equal(undefined)
done()
})
.catch(done)
})
it('should not refresh token when error_code is 294 (2FA required) with 401 status', done => {
let refreshTokenCallCount = 0
const refreshTokenStub = sinon.stub().callsFake(() => {
refreshTokenCallCount++
return Promise.resolve({ authorization: 'Bearer new_token' })
})
const axiosWithRefresh = client({
baseURL: `${host}:${port}`,
authorization: 'Bearer <token_value>',
refreshToken: refreshTokenStub
})
const mock = new MockAdapter(axiosWithRefresh.axiosInstance)
mock.onGet('/test2fa').reply(401, {
error_message: 'Please login using the Two-Factor verification Token',
error_code: 294,
errors: [],
statusCode: 401,
tfa_type: 'totp_authenticator'
})
axiosWithRefresh.axiosInstance.get('/test2fa')
.then(() => {
done(new Error('Expected error was not thrown'))
})
.catch((error) => {
// Verify refreshToken was NOT called
expect(refreshTokenCallCount).to.equal(0)
expect(refreshTokenStub.called).to.equal(false)
// Verify the raw error response has error_code 294
expect(error.response.status).to.equal(401)
expect(error.response.data.error_code).to.equal(294)
expect(error.response.data.error_message).to.include('Two-Factor verification')
expect(error.response.data.tfa_type).to.equal('totp_authenticator')
done()
})
.catch(done)
})
it('should refresh token when 401 status without error_code 294', done => {
const axios2 = client({
baseURL: `${host}:${port}`
})
const axios = client({
baseURL: `${host}:${port}`,
authorization: 'Bearer <token_value>',
refreshToken: () => {
return new Promise((resolve, reject) => {
return axios2.login().then((res) => {
resolve({ authorization: res.token })
}).catch((error) => {
reject(error)
})
})
}
})
// First request will fail with 401, trigger refresh, then succeed
axios.axiosInstance.get('/unauthorized')
.then((response) => {
// Should succeed after token refresh
expect(response.data.randomInteger).to.equal(123)
done()
})
.catch(done)
})
it('should preserve error_code 294 when present with 401 status', done => {
const refreshTokenStub = sinon.stub()
refreshTokenStub.returns(Promise.resolve({ authorization: 'Bearer new_token' }))
const axiosWithRefresh = client({
baseURL: `${host}:${port}`,
authorization: 'Bearer <token_value>',
refreshToken: refreshTokenStub
})
const mock = new MockAdapter(axiosWithRefresh.axiosInstance)
mock.onGet('/test2fa294').reply(401, {
error_message: 'Please login using the Two-Factor verification Token',
error_code: 294,
errors: [],
statusCode: 401,
tfa_type: 'totp_authenticator'
})
axiosWithRefresh.axiosInstance.get('/test2fa294')
.then(() => {
done(new Error('Expected error was not thrown'))
})
.catch((error) => {
// Verify refreshToken was NOT called
expect(refreshTokenStub.called).to.equal(false)
// Verify the raw error response preserves error_code 294
expect(error.response.status).to.equal(401)
expect(error.response.data.error_code).to.equal(294)
expect(error.response.data.error_message).to.include('Two-Factor verification')
expect(error.response.data.tfa_type).to.equal('totp_authenticator')
// The key test: error_code 294 should be preserved in response.data
// This ensures our fix in concurrency-queue.js is working (no token refresh attempted)
done()
})
.catch(done)
})
})
function makeConcurrencyQueue (config) {
return new ConcurrencyQueue({ axios, config })
}