-
Notifications
You must be signed in to change notification settings - Fork 12
Open
Description
Problem Statement
The color of diff is a bit confusing.
As seen in Oded-B/telefonistka-example#155 (comment) the diff shows the following:
--- clusters/staging/europe-west4/c1/nginx/values.yaml
+++ clusters/prod/us-west1/c2/nginx/values.yaml
@@ -11,7 +11,7 @@
service:
type: ClusterIP
- port: 9000
+ port: 80
ingress:
enabled: false
--- clusters/staging/europe-west4/c1/nginx/Chart.yaml
+++ clusters/prod/us-west1/c2/nginx/Chart.yaml
@@ -21,5 +21,3 @@
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
appVersion: "1.0"
-
-#test3
+++ clusters/prod/us-west1/c2/nginx/values-region-eu-west1.yaml (missing from source dir clusters/staging/europe-west4/c1/nginx)
I think it makes more sense to switch the color and also the --- & +++ signs because currently it looks like that the values from the source clusters/staging/europe-west4/c1/nginx/values.yaml are replaced by the values of the target clusters/prod/us-west1/c2/nginx/values.yaml but it's the way around.
Proposed Solution
Switch the color and signs for source and target in the diff explanation.
Alternatives Considered
Only alternative is to have in mind that the shown explanation needs to be interpreted as vice versa.
Additional Context
None
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels