Skip to content

Commit 20ef000

Browse files
authored
Merge pull request #49 from codecov/self-hosted-ux
Change UX for host permission
2 parents 2f84357 + 78d3900 commit 20ef000

File tree

1 file changed

+23
-19
lines changed

1 file changed

+23
-19
lines changed

src/popup/main.tsx

Lines changed: 23 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -171,13 +171,29 @@ const Popup = () => {
171171
>
172172
Codecov
173173
</a>
174-
<button
175-
onClick={handleSave}
176-
disabled={isDone || isFormInvalid || isError}
177-
className="btn btn-ghost text-white"
178-
>
179-
{isDone ? "Done" : isError ? "Error" : "Save"}
180-
</button>
174+
<div className="space-x-2">
175+
{useSelfHosted && !isDone && (
176+
<div
177+
className="tooltip tooltip-bottom"
178+
data-tip="The extension needs explicit permission to make requests to self hosted Codecov"
179+
>
180+
<button
181+
onClick={requestHostPermission}
182+
disabled={isUrlPermissionGranted}
183+
className="btn btn-ghost text-white"
184+
>
185+
Grant Permission
186+
</button>
187+
</div>
188+
)}
189+
<button
190+
onClick={handleSave}
191+
disabled={isDone || isFormInvalid || isError}
192+
className="btn btn-ghost text-white"
193+
>
194+
{isDone ? "Done" : isError ? "Error" : "Save"}
195+
</button>
196+
</div>
181197
{/*<div className="pr-4">*/}
182198
{/* <FontAwesomeIcon icon={faCircleNotch} spin color="white" size="xl" />*/}
183199
{/*</div>*/}
@@ -219,19 +235,7 @@ const Popup = () => {
219235
value={codecovUrl}
220236
onChange={handleTextChange(setCodecovUrl)}
221237
/>
222-
<button
223-
disabled={isUrlPermissionGranted}
224-
className="btn btn-square btn-ghost"
225-
onClick={requestHostPermission}
226-
>
227-
<FontAwesomeIcon icon={faSquareCheck} size="xl" />
228-
</button>
229238
</div>
230-
<label className="label">
231-
<span className="label-text-alt">
232-
You must click the checkbox and allow permissions
233-
</span>
234-
</label>
235239
{isUrlError && (
236240
<label className="label">
237241
<span className="label-text-alt text-red-500">

0 commit comments

Comments
 (0)