Skip to content

Commit d61b1fa

Browse files
authored
Merge pull request #159185 from dhartunian/blathers/backport-release-26.1-159096
release-26.1: cli: skip some zip tests under deadlock
2 parents 9968c43 + cdfcfab commit d61b1fa

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

pkg/cli/zip_test.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -718,6 +718,7 @@ func TestPartialZip(t *testing.T) {
718718
// however low timeouts make race runs flaky with false positives.
719719
skip.UnderShort(t)
720720
skip.UnderRace(t)
721+
skip.UnderDeadlock(t, "flaky under deadlock")
721722

722723
sc := log.ScopeWithoutShowLogs(t)
723724
defer sc.Close(t)
@@ -830,6 +831,7 @@ func TestZipDisallowFullScans(t *testing.T) {
830831

831832
skip.UnderShort(t)
832833
skip.UnderRace(t)
834+
skip.UnderDeadlock(t, "flaky under deadlock")
833835

834836
dir, cleanupFn := testutils.TempDir(t)
835837
defer cleanupFn()
@@ -1501,6 +1503,8 @@ func TestZipIncludeAndExcludeFilesDataDriven(t *testing.T) {
15011503
defer leaktest.AfterTest(t)()
15021504
defer log.Scope(t).Close(t)
15031505

1506+
skip.UnderDeadlock(t, "flaky under deadlock")
1507+
15041508
datadriven.Walk(t, "testdata/zip/file-filters", func(t *testing.T, path string) {
15051509
datadriven.RunTest(t, path, func(t *testing.T, d *datadriven.TestData) string {
15061510
// We want a low timeout so that the test doesn't take forever;

0 commit comments

Comments
 (0)