kvnemesis: treat pg replica unavailable as an unavailable error

iskettaneh · iskettaneh · commit 8adfc52c8b32 · 2025-12-03T13:21:19.000-05:00
This commit expands the condition where we expect a replica unavailable to include pg replica unavailable errors. This will apply to SQL requests that hit things like the leaderless watcher due to a known unavailability Fixes: #158683 Release note: None
diff --git a/pkg/kv/kvnemesis/applier.go b/pkg/kv/kvnemesis/applier.go
@@ -114,7 +114,8 @@ func exceptConditionFailed(err error) bool {
 }
 
 func exceptReplicaUnavailable(err error) bool {
-	return errors.HasType(err, (*kvpb.ReplicaUnavailableError)(nil))
+	return errors.HasType(err, (*kvpb.ReplicaUnavailableError)(nil)) ||
+		strings.Contains(err.Error(), "replica unavailable")
 }
 
 func exceptContextCanceled(err error) bool {

Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,8 @@ func exceptConditionFailed(err error) bool {`
`114`	`114`	`}`
`115`	`115`
`116`	`116`	`func exceptReplicaUnavailable(err error) bool {`
`117`		`- return errors.HasType(err, (*kvpb.ReplicaUnavailableError)(nil))`
	`117`	`+ return errors.HasType(err, (*kvpb.ReplicaUnavailableError)(nil)) \|\|`
	`118`	`+ strings.Contains(err.Error(), "replica unavailable")`
`118`	`119`	`}`
`119`	`120`
`120`	`121`	`func exceptContextCanceled(err error) bool {`