Skip to content

Commit 4f99430

Browse files
committed
sst: fix warnings in .proto files
This fixes the following warnings for fields recently added for the distributed merge work: ``` WARNING: field SSTFileInfo.StartKey is a non-nullable bytes type, nullable=false has no effect WARNING: field SSTFileInfo.EndKey is a non-nullable bytes type, nullable=false has no effect WARNING: field SSTFiles.RowSamples is a repeated non-nullable native type, nullable=false has no effect ``` Epic: CRDB-48845 Release notes: none
1 parent 70ac59b commit 4f99430

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

pkg/sql/bulksst/sst_info.proto

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,14 @@ import "gogoproto/gogo.proto";
1111

1212
message SSTFileInfo {
1313
required string uri = 1 [(gogoproto.nullable) = false, (gogoproto.customname) = "URI"];;
14-
required bytes start_key = 2 [(gogoproto.nullable) = false, (gogoproto.casttype) = "github.com/cockroachdb/cockroach/pkg/roachpb.Key"];
15-
required bytes end_key = 3 [(gogoproto.nullable) = false, (gogoproto.casttype) = "github.com/cockroachdb/cockroach/pkg/roachpb.Key"];
14+
required bytes start_key = 2 [(gogoproto.casttype) = "github.com/cockroachdb/cockroach/pkg/roachpb.Key"];
15+
required bytes end_key = 3 [(gogoproto.casttype) = "github.com/cockroachdb/cockroach/pkg/roachpb.Key"];
1616
required uint64 file_size = 4 [(gogoproto.nullable) = false];
1717
optional bytes row_sample = 5 [(gogoproto.casttype) = "github.com/cockroachdb/cockroach/pkg/roachpb.Key"];
1818
}
1919

2020
message SSTFiles {
2121
repeated SSTFileInfo sst = 1 [(gogoproto.customname) = "SST"];
22-
repeated string row_samples = 2 [(gogoproto.nullable) = false];
22+
repeated string row_samples = 2;
2323
required uint64 total_size = 3 [(gogoproto.nullable) = false];
2424
}

0 commit comments

Comments
 (0)