Skip to content

Commit 47f9cca

Browse files
authored
Merge pull request #159151 from miraradeva/backport24.3-157166
release-24.3: roachtest: disable global follower reads test in shared process mode
2 parents da2310c + 97d6462 commit 47f9cca

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

pkg/cmd/roachtest/tests/follower_reads.go

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1023,13 +1023,17 @@ func runFollowerReadsMixedVersionGlobalTableTest(
10231023
// this issue.
10241024
mixedversion.MinimumSupportedVersion("v23.2.0"),
10251025

1026-
// This test does not currently work with shared-process
1027-
// deployments (#129167), so we do not run it in separate-process
1028-
// mode either to reduce noise. We should reevaluate once the test
1029-
// works in shared-process.
1026+
// This test is incompatible with separate process mode as it queries metrics from
1027+
// TSDB. Separate process clusters currently do not write to TSDB as serverless uses
1028+
// third party metrics persistence solutions instead.
1029+
//
1030+
// TODO(darrylwong): Once #137625 is complete, we can switch to querying prometheus using
1031+
// `clusterstats` instead and re-enable separate process.
1032+
//
1033+
// This test is flaky in shared process mode, so it is temporarily disabled to reduce noise.
1034+
// TODO(server): #157164 is the tracking issue to re-enable this.
10301035
mixedversion.EnabledDeploymentModes(
10311036
mixedversion.SystemOnlyDeployment,
1032-
mixedversion.SharedProcessDeployment,
10331037
),
10341038
)
10351039
}

0 commit comments

Comments
 (0)