sql: consolidate logic for TTL rate limit notice

Release note: None

Author: rafiss

pkg/sql/alter_table.go

@@ -768,13 +768,6 @@ func (n *alterTableNode) startExec(params runParams) error {
 				return err
 			}
 
-			paramIsDelete := t.StorageParams.GetVal("ttl_delete_rate_limit") != nil
-			paramIsSelect := t.StorageParams.GetVal("ttl_select_rate_limit") != nil
-
-			if paramIsDelete || paramIsSelect {
-				printTTLRateLimitNotice(params.ctx, params.p)
-			}
-
 		case *tree.AlterTableResetStorageParams:
 			setter := tablestorageparam.NewSetter(n.tableDesc, false /* isNewObject */)
 			if err := storageparam.Reset(

pkg/sql/create_table.go

@@ -1431,13 +1431,6 @@ func NewTableDesc(
 		return nil, err
 	}
 
-	paramIsDelete := n.StorageParams.GetVal("ttl_delete_rate_limit") != nil
-	paramIsSelect := n.StorageParams.GetVal("ttl_select_rate_limit") != nil
-
-	if paramIsDelete || paramIsSelect {
-		printTTLRateLimitNotice(ctx, evalCtx.ClientNoticeSender)
-	}
-
 	setter.TableDesc.RowLevelTTL = setter.UpdatedRowLevelTTL
 
 	indexEncodingVersion := descpb.StrictIndexColumnIDGuaranteesVersion

pkg/sql/storageparam/BUILD.bazel

@@ -6,6 +6,7 @@ go_library(
     importpath = "github.com/cockroachdb/cockroach/pkg/sql/storageparam",
     visibility = ["//visibility:public"],
     deps = [
+        "//pkg/docs",
         "//pkg/server/telemetry",
         "//pkg/sql/paramparse",
         "//pkg/sql/pgwire/pgcode",

pkg/sql/storageparam/storage_param.go

@@ -10,6 +10,7 @@ package storageparam
 import (
 	"context"
 
+	"github.com/cockroachdb/cockroach/pkg/docs"
 	"github.com/cockroachdb/cockroach/pkg/server/telemetry"
 	"github.com/cockroachdb/cockroach/pkg/sql/paramparse"
 	"github.com/cockroachdb/cockroach/pkg/sql/pgwire/pgcode"
@@ -150,6 +151,7 @@ func StorageParamPreChecks(
 	}
 	keys = append(keys, resetParams...)
 
+	hasTTLRateLimit := false
 	for _, key := range keys {
 		if key == `schema_locked` {
 			// We only allow setting/resetting `schema_locked` storage parameter in
@@ -168,6 +170,17 @@ func StorageParamPreChecks(
 					"its own without other parameters in a single-statement implicit transaction.", key)
 			}
 		}
+		if key == `ttl_select_rate_limit` || key == `ttl_delete_rate_limit` {
+			hasTTLRateLimit = true
+		}
+	}
+
+	if hasTTLRateLimit {
+		evalCtx.ClientNoticeSender.BufferClientNotice(ctx, errors.WithDetail(
+			pgnotice.Newf("The TTL rate limit is per node per table."),
+			"See the documentation for additional details: "+docs.URL("row-level-ttl#ttl-storage-parameters"),
+		))
 	}
+
 	return nil
 }