Merge #159276

159276: schemachanger: support metadata-only TTL parameters and ttl_job_cron r=rafiss a=rafiss

See individual commits.

### schemachanger: handle basic TTL params

The builder was updated so that it modifies the scpb.RowLevelTTL element
for when handling TTL storage params. This is needed so that we can do
proper validation on the TTL params, since the validation logic checks
dependencies between different parameters.

The UpsertRowLevelTTL immediate mutation takes care of modifying the
descriptor. Logic was also needed to avoid dropping the TTL schedule if
we are modifying parameters.

### schemachanger: support ttl_job_cron parameter in declarative schema changer

Previously, modifying the ttl_job_cron storage parameter required falling
back to the legacy schema changer because the declarative schema changer
had no mechanism to update the TTL scheduled job's cron expression.

This commit adds support for ttl_job_cron by:

1. Adding UpdateTTLScheduleCron as a new deferred mutation operation that
    updates the cron expression on the existing TTL scheduled job.

2. Implementing findOldTTLCron in opgen to detect when the cron expression
    has changed by comparing the new RowLevelTTL element against the one
    being dropped, emitting UpdateTTLScheduleCron only when necessary.

3. Adding UpdateTTLScheduleCron to metadataUpdater which loads the
    scheduled job, updates its cron expression, and persists the change.

informs: #122379
Release note: None

Co-authored-by: Rafi Shamim <[email protected]>

Author: craig[bot]

pkg/sql/GEMINI.md

@@ -768,13 +768,6 @@ func (n *alterTableNode) startExec(params runParams) error {
 				return err
 			}
 
-			paramIsDelete := t.StorageParams.GetVal("ttl_delete_rate_limit") != nil
-			paramIsSelect := t.StorageParams.GetVal("ttl_select_rate_limit") != nil
-
-			if paramIsDelete || paramIsSelect {
-				printTTLRateLimitNotice(params.ctx, params.p)
-			}
-
 		case *tree.AlterTableResetStorageParams:
 			setter := tablestorageparam.NewSetter(n.tableDesc, false /* isNewObject */)
 			if err := storageparam.Reset(

pkg/sql/alter_table.go

@@ -1431,13 +1431,6 @@ func NewTableDesc(
 		return nil, err
 	}
 
-	paramIsDelete := n.StorageParams.GetVal("ttl_delete_rate_limit") != nil
-	paramIsSelect := n.StorageParams.GetVal("ttl_select_rate_limit") != nil
-
-	if paramIsDelete || paramIsSelect {
-		printTTLRateLimitNotice(ctx, evalCtx.ClientNoticeSender)
-	}
-
 	setter.TableDesc.RowLevelTTL = setter.UpdatedRowLevelTTL
 
 	indexEncodingVersion := descpb.StrictIndexColumnIDGuaranteesVersion

pkg/sql/create_table.go

@@ -6,8 +6,10 @@ go_library(
     importpath = "github.com/cockroachdb/cockroach/pkg/sql/descmetadata",
     visibility = ["//visibility:public"],
     deps = [
+        "//pkg/jobs",
         "//pkg/jobs/jobspb",
         "//pkg/keys",
+        "//pkg/scheduledjobs",
         "//pkg/settings",
         "//pkg/sql/catalog",
         "//pkg/sql/catalog/descpb",

pkg/sql/descmetadata/BUILD.bazel

@@ -9,8 +9,10 @@ import (
 	"context"
 	"fmt"
 
+	"github.com/cockroachdb/cockroach/pkg/jobs"
 	"github.com/cockroachdb/cockroach/pkg/jobs/jobspb"
 	"github.com/cockroachdb/cockroach/pkg/keys"
+	"github.com/cockroachdb/cockroach/pkg/scheduledjobs"
 	"github.com/cockroachdb/cockroach/pkg/settings"
 	"github.com/cockroachdb/cockroach/pkg/sql/catalog"
 	"github.com/cockroachdb/cockroach/pkg/sql/catalog/descpb"
@@ -113,3 +115,19 @@ func (mu metadataUpdater) UpdateTTLScheduleLabel(
 	)
 	return err
 }
+
+// UpdateTTLScheduleCron implement scexec.DescriptorMetadataUpdater.
+func (mu metadataUpdater) UpdateTTLScheduleCron(
+	ctx context.Context, scheduleID jobspb.ScheduleID, cronExpr string,
+) error {
+	env := scheduledjobs.ProdJobSchedulerEnv
+	schedules := jobs.ScheduledJobTxn(mu.txn)
+	s, err := schedules.Load(ctx, env, scheduleID)
+	if err != nil {
+		return err
+	}
+	if err := s.SetScheduleAndNextRun(cronExpr); err != nil {
+		return err
+	}
+	return schedules.Update(ctx, s)
+}