feat(pages_domain): convert tf-migrate logic to state upgraders

Author: rotem-cloud

e2e/drift-exemptions/zone_dnssec.yaml

@@ -13,6 +13,22 @@ exemptions:
       - '\+ status\s*=\s*"active"'  # Allow adding status = "active"
     enabled: true
 
+  # Computed fields refresh when status changes
+  - name: "computed_fields_refresh"
+    description: "All computed fields refresh to (known after apply) when DNSSEC status changes"
+    patterns:
+      - 'algorithm\s*=.*->\s*\(known after apply\)'
+      - 'digest\s*=.*->\s*\(known after apply\)'
+      - 'digest_algorithm\s*=.*->\s*\(known after apply\)'
+      - 'digest_type\s*=.*->\s*\(known after apply\)'
+      - 'ds\s*=.*->\s*\(known after apply\)'
+      - 'flags\s*=.*->\s*\(known after apply\)'
+      - 'key_tag\s*=.*->\s*\(known after apply\)'
+      - 'key_type\s*=.*->\s*\(known after apply\)'
+      - 'modified_on\s*=.*->\s*\(known after apply\)'
+      - 'public_key\s*=.*->\s*\(known after apply\)'
+    enabled: true
+
 settings:
   apply_exemptions: true
   verbose_exemptions: false

integration/v4_to_v5/testdata/pages_domain/expected/pages_domain.tf

@@ -1,14 +1,19 @@
+# Locals for prefix
+locals {
+  prefix = "cftftest"
+}
+
 # Basic pages_domain resource
 resource "cloudflare_pages_domain" "basic" {
   account_id   = "f037e56e89293a057740de681ac9abbe"
-  project_name = "my-project"
-  name         = "example.com"
+  project_name = "${local.prefix}-my-project"
+  name         = "${local.prefix}-example.com"
 }
 
 # With project reference
 resource "cloudflare_pages_project" "example" {
   account_id        = "f037e56e89293a057740de681ac9abbe"
-  name              = "my-project"
+  name              = "${local.prefix}-my-project"
   production_branch = "main"
   deployment_configs = {
     preview = {
@@ -25,20 +30,20 @@ resource "cloudflare_pages_project" "example" {
 resource "cloudflare_pages_domain" "with_reference" {
   account_id   = "f037e56e89293a057740de681ac9abbe"
   project_name = cloudflare_pages_project.example.name
-  name         = "prod.example.com"
+  name         = "${local.prefix}-prod.example.com"
 }
 
 # Multiple domains for same project
 resource "cloudflare_pages_domain" "staging" {
   account_id   = "f037e56e89293a057740de681ac9abbe"
-  project_name = "my-project"
-  name         = "staging.example.com"
+  project_name = "${local.prefix}-my-project"
+  name         = "${local.prefix}-staging.example.com"
 }
 
 resource "cloudflare_pages_domain" "dev" {
   account_id   = "f037e56e89293a057740de681ac9abbe"
-  project_name = "my-project"
-  name         = "dev.example.com"
+  project_name = "${local.prefix}-my-project"
+  name         = "${local.prefix}-dev.example.com"
 }
 
 # With variables
@@ -61,37 +66,35 @@ resource "cloudflare_pages_domain" "with_vars" {
 }
 
 # Using for_each with map
-variable "domains" {
-  type = map(string)
-  default = {
-    prod    = "prod.example.com"
-    staging = "staging.example.com"
-    dev     = "dev.example.com"
+locals {
+  domains = {
+    prod    = "${local.prefix}-prod.example.com"
+    staging = "${local.prefix}-staging.example.com"
+    dev     = "${local.prefix}-dev.example.com"
   }
 }
 
 resource "cloudflare_pages_domain" "for_each_map" {
-  for_each = var.domains
+  for_each = local.domains
 
   account_id   = "f037e56e89293a057740de681ac9abbe"
-  project_name = "my-project"
+  project_name = "${local.prefix}-my-project"
   name         = each.value
 }
 
 # Using for_each with set
-variable "domain_list" {
-  type = set(string)
-  default = [
-    "api.example.com",
-    "www.example.com",
-  ]
+locals {
+  domain_list = toset([
+    "${local.prefix}-api.example.com",
+    "${local.prefix}-www.example.com",
+  ])
 }
 
 resource "cloudflare_pages_domain" "for_each_set" {
-  for_each = var.domain_list
+  for_each = local.domain_list
 
   account_id   = "f037e56e89293a057740de681ac9abbe"
-  project_name = "my-project"
+  project_name = "${local.prefix}-my-project"
   name         = each.value
 }
 
@@ -100,8 +103,8 @@ resource "cloudflare_pages_domain" "with_count" {
   count = 2
 
   account_id   = "f037e56e89293a057740de681ac9abbe"
-  project_name = "my-project"
-  name         = "domain${count.index}.example.com"
+  project_name = "${local.prefix}-my-project"
+  name         = "${local.prefix}-domain${count.index}.example.com"
 }
 
 # With conditional creation
@@ -114,19 +117,19 @@ resource "cloudflare_pages_domain" "conditional" {
   count = var.create_custom_domain ? 1 : 0
 
   account_id   = "f037e56e89293a057740de681ac9abbe"
-  project_name = "my-project"
-  name         = "conditional.example.com"
+  project_name = "${local.prefix}-my-project"
+  name         = "${local.prefix}-conditional.example.com"
 }
 
-# With locals
+# With locals (additional locals block)
 locals {
   account_id   = "f037e56e89293a057740de681ac9abbe"
-  project_name = "my-project"
+  project_name = "${local.prefix}-my-project"
   base_domain  = "example.com"
 }
 
 resource "cloudflare_pages_domain" "with_locals" {
   account_id   = local.account_id
   project_name = local.project_name
-  name         = "app.${local.base_domain}"
+  name         = "${local.prefix}-app.${local.base_domain}"
 }