chore(custom_pages): adjust for state upgraders logic (#206)

Author: rotem-cloud

integration/v4_to_v5/testdata/custom_pages/expected/custom_pages.tf

@@ -14,10 +14,15 @@ variable "cloudflare_domain" {
   type        = string
 }
 
+# URL for custom pages - this URL contains the required tokens for all error page types
+locals {
+  custom_pages_url = "https://custom-pages-basic.terraform-provider-acceptance-testing.workers.dev/"
+}
+
 # Basic zone-scoped custom page with real URL
 resource "cloudflare_custom_pages" "error_500" {
   zone_id    = var.cloudflare_zone_id
-  url        = "https://custom-pages-500-error-for-e2e.terraform-testing-a09.workers.dev/"
+  url        = local.custom_pages_url
   state      = "customized"
   identifier = "500_errors"
 }

integration/v4_to_v5/testdata/custom_pages/expected/terraform.tfstate

@@ -14,10 +14,15 @@ variable "cloudflare_domain" {
   type        = string
 }
 
+# URL for custom pages - this URL contains the required tokens for all error page types
+locals {
+  custom_pages_url = "https://custom-pages-basic.terraform-provider-acceptance-testing.workers.dev/"
+}
+
 # Basic zone-scoped custom page with real URL
 resource "cloudflare_custom_pages" "error_500" {
   zone_id = var.cloudflare_zone_id
   type    = "500_errors"
-  url     = "https://custom-pages-500-error-for-e2e.terraform-testing-a09.workers.dev/"
+  url     = local.custom_pages_url
   state   = "customized"
 }

integration/v4_to_v5/testdata/custom_pages/input/custom_pages.tf

@@ -3,7 +3,6 @@ package custom_pages
 import (
 	"github.com/hashicorp/hcl/v2/hclwrite"
 	"github.com/tidwall/gjson"
-	"github.com/tidwall/sjson"
 
 	"github.com/cloudflare/tf-migrate/internal"
 	"github.com/cloudflare/tf-migrate/internal/transform"
@@ -67,33 +66,15 @@ func (m *V4ToV5Migrator) TransformConfig(ctx *transform.Context, block *hclwrite
 }
 
 // TransformState handles state file transformations.
-// This function receives a single resource instance and returns the transformed instance JSON.
+// State transformation is handled by the provider's StateUpgraders (UpgradeState).
 func (m *V4ToV5Migrator) TransformState(ctx *transform.Context, stateJSON gjson.Result, resourcePath, resourceName string) (string, error) {
-	result := stateJSON.String()
-
-	// Check if it's a valid custom_pages instance
-	if !stateJSON.Exists() || !stateJSON.Get("attributes").Exists() {
-		// Even for invalid instances, set schema_version for v5
-		result, _ = sjson.Set(result, "schema_version", 0)
-		return result, nil
-	}
-
-	attrs := stateJSON.Get("attributes")
-
-	// 1. type → identifier
-	if typeField := attrs.Get("type"); typeField.Exists() {
-		result, _ = sjson.Set(result, "attributes.identifier", typeField.Value())
-		result, _ = sjson.Delete(result, "attributes.type")
-	}
-
-	// 2. Ensure state field exists (required in v5, optional in v4)
-	if !attrs.Get("state").Exists() {
-		// Add default value if missing
-		result, _ = sjson.Set(result, "attributes.state", "default")
-	}
-
-	// 3. Set schema_version to 0 for v5
-	result, _ = sjson.Set(result, "schema_version", 0)
+	// State passthrough - provider handles all state migration
+	return stateJSON.String(), nil
+}
 
-	return result, nil
+// UsesProviderStateUpgrader indicates that this resource uses provider-based state migration.
+// This tells tf-migrate that the provider's StateUpgraders (UpgradeState) handle all state
+// transformation, not tf-migrate's TransformState function.
+func (m *V4ToV5Migrator) UsesProviderStateUpgrader() bool {
+	return true
 }

integration/v4_to_v5/testdata/custom_pages/input/terraform.tfstate

@@ -98,83 +98,8 @@ resource "cloudflare_custom_pages" "error_1000" {
 		testhelpers.RunConfigTransformTests(t, tests, migrator)
 	})
 
-	// Test state transformations
-	t.Run("StateTransformation", func(t *testing.T) {
-		tests := []testhelpers.StateTestCase{
-			{
-				Name: "basic state transformation",
-				Input: `{
-  "schema_version": 0,
-  "attributes": {
-    "id": "500_errors",
-    "zone_id": "14e48053f1836c10cb86ba178633826a",
-    "account_id": null,
-    "type": "500_errors",
-    "url": "https://cf-tf-test.com/500.html",
-    "state": "customized"
-  }
-}`,
-				Expected: `{
-  "schema_version": 0,
-  "attributes": {
-    "id": "500_errors",
-    "zone_id": "14e48053f1836c10cb86ba178633826a",
-    "account_id": null,
-    "identifier": "500_errors",
-    "url": "https://cf-tf-test.com/500.html",
-    "state": "customized"
-  }
-}`,
-			},
-			{
-				Name: "state transformation with missing state field",
-				Input: `{
-  "schema_version": 0,
-  "attributes": {
-    "id": "500_errors",
-    "zone_id": "14e48053f1836c10cb86ba178633826a",
-    "type": "500_errors",
-    "url": "https://cf-tf-test.com/500.html"
-  }
-}`,
-				Expected: `{
-  "schema_version": 0,
-  "attributes": {
-    "id": "500_errors",
-    "zone_id": "14e48053f1836c10cb86ba178633826a",
-    "identifier": "500_errors",
-    "url": "https://cf-tf-test.com/500.html",
-    "state": "default"
-  }
-}`,
-			},
-			{
-				Name: "account-scoped state",
-				Input: `{
-  "schema_version": 0,
-  "attributes": {
-    "id": "basic_challenge",
-    "account_id": "dbb2ef7988061049c4bd32bf6883fde0",
-    "zone_id": null,
-    "type": "basic_challenge",
-    "url": "https://cf-tf-test.com/challenge.html",
-    "state": "default"
-  }
-}`,
-				Expected: `{
-  "schema_version": 0,
-  "attributes": {
-    "id": "basic_challenge",
-    "account_id": "dbb2ef7988061049c4bd32bf6883fde0",
-    "zone_id": null,
-    "identifier": "basic_challenge",
-    "url": "https://cf-tf-test.com/challenge.html",
-    "state": "default"
-  }
-}`,
-			},
-		}
-
-		testhelpers.RunStateTransformTests(t, tests, migrator)
+	// State transformation tests removed - state migration is now handled by provider's StateUpgraders
+	t.Run("StateTransformation_Removed", func(t *testing.T) {
+		t.Skip("State transformation tests removed - state migration is now handled by provider's StateUpgraders")
 	})
 }