refactor(select): use Base UI native placeholder prop#172
Merged
geoquant merged 2 commits intocloudflare:mainfrom Mar 4, 2026
Merged
refactor(select): use Base UI native placeholder prop#172geoquant merged 2 commits intocloudflare:mainfrom
geoquant merged 2 commits intocloudflare:mainfrom
Conversation
Simplify Select placeholder implementation by using Base UI's native placeholder prop on SelectBase.Value instead of manually injecting placeholder items into the items array. This provides a cleaner, more intuitive API that aligns with standard HTML select behavior while maintaining backward compatibility with the null-value placeholder pattern. Changes: - Add placeholder prop support to Select.Value component - Remove placeholder item injection logic from Select component - Add comprehensive tests for placeholder functionality - Update documentation with both placeholder approaches - Filter null-value items from auto-rendered options
commit: |
Contributor
Docs PreviewCommit: |
mattrothenberg
approved these changes
Mar 4, 2026
Collaborator
|
Awesome! This is a great improvement. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.







































Summary
Since we have upgraded to BaseUI to 1.2.0, we can now use the native placeholder (https://base-ui.com/react/overview/releases/v1-1-0#select). This simplifies the Select component's implementation by removing the need to manually inject placeholder items into the items array.
Benefits
Changes
placeholderprop support toSelect.ValuecomponentTesting