Ignore Frame Size Errors in defintions.amqp

There was a bug in frame size calulcation of exchange to exchange
binding frames which addes two bytes to the frame size. In a newer
version of amq-protocol frame size validation is enforced, so if there
was a e2e binding frame in the `defintions.amqp` file on boot, it
prevented the server from starting.

With amq-protocl 1.1.20 fixes compability with e2e bindings

From old versions (amq-protocol <1.1.16, lavinmq <2.5.0)

Author: carlhoerberg

shard.lock

@@ -6,7 +6,7 @@ shards:
 
   amq-protocol:
     git: https://github.com/cloudamqp/amq-protocol.cr.git
-    version: 1.1.19
+    version: 1.1.20
 
   amqp-client:
     git: https://github.com/cloudamqp/amqp-client.cr.git

spec/definitions_frame_size_spec.cr

@@ -0,0 +1,26 @@
+require "./spec_helper"
+require "file_utils"
+
+describe LavinMQ::VHost do
+  it "should handle definitions files from v2.4.3 with frame size errors" do
+    Dir.mkdir_p File.join(LavinMQ::Config.instance.data_dir, "a94a8fe5ccb19ba61c4c0873d391e987982fbbd3")
+    File.open(File.join(LavinMQ::Config.instance.data_dir, "vhosts.json"), "w") do |f|
+      [{"name": "test", "dir": "a94a8fe5ccb19ba61c4c0873d391e987982fbbd3"}].to_json(f)
+    end
+    FileUtils.cp(
+      File.join(__DIR__, "fixtures", "v243_e2e_binding.amqp"),
+      File.join(
+        LavinMQ::Config.instance.data_dir,
+        "a94a8fe5ccb19ba61c4c0873d391e987982fbbd3",
+        "definitions.amqp"
+      )
+    )
+    with_amqp_server do |s|
+      exchanges = s.vhosts["test"].exchanges
+      src_x = exchanges["source.exchange"]
+      dst_x = exchanges["destination.exchange"]
+      src_x.bindings_details.to_a.should_not be_empty
+      dst_x.bindings_details.to_a.should_not be_empty
+    end
+  end
+end

spec/fixtures/v243_e2e_binding.amqp

@@ -97,7 +97,6 @@ def with_amqp_server(tls = false, replicator = nil,
                      config = LavinMQ::Config.instance,
                      file = __FILE__, line = __LINE__, & : LavinMQ::Server -> Nil)
   LavinMQ::Config.instance = init_config(config)
-  FileUtils.rm_rf(config.data_dir)
   tcp_server = TCPServer.new("localhost", ENV.has_key?("NATIVE_PORTS") ? 5672 : 0)
   s = LavinMQ::Server.new(config, replicator)
   begin