Skip to content

Commit f8ce1ed

Browse files
authored
CI - Fix v8 in debug and release (#4223)
# Description of Changes #4209 changed our v8 patch to fix release builds.. but it turns out that the csharp-testsuite uses both debug _and_ release builds. # API and ABI breaking changes None. CI only. # Expected complexity level and risk 1 # Testing I dunno mannnn Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
1 parent d3f5948 commit f8ce1ed

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

.github/workflows/ci.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -849,6 +849,12 @@ jobs:
849849
# However, we've been unable to fix it so... /shrug
850850
- name: Check v8 outputs
851851
run: |
852+
find "${CARGO_TARGET_DIR}"/ -type f | grep '[/_]v8' || true
853+
if ! [ -f "${CARGO_TARGET_DIR}"/debug/gn_out/obj/librusty_v8.a ]; then
854+
echo "Could not find v8 output file librusty_v8.a; rebuilding manually."
855+
cargo clean -p v8 || true
856+
cargo build -p v8
857+
fi
852858
find "${CARGO_TARGET_DIR}"/ -type f | grep '[/_]v8' || true
853859
if ! [ -f "${CARGO_TARGET_DIR}"/release/gn_out/obj/librusty_v8.a ]; then
854860
echo "Could not find v8 output file librusty_v8.a; rebuilding manually."

0 commit comments

Comments
 (0)