Only look at the base path in readiness check (#200)

This is to ensure the readiness check for service containers, which depends on a file notification, works on Windows. We were comparing the event name with the path, but this path wasn't localized, so the match would fail on Windows. Instead, we can just look at the base of the path since we only set up the watcher on the containing directory.

Author: christian-stephen

task/orchestrator.go

@@ -144,7 +144,7 @@ func (o *Orchestrator) waitForReadiness(ctx context.Context) (err error) {
 	for {
 		select {
 		case event, ok := <-watcher.Events:
-			if ok && event.Has(fsnotify.Create) && event.Name == readinessFilePath {
+			if ok && event.Has(fsnotify.Create) && filepath.Base(event.Name) == filepath.Base(readinessFilePath) {
 				return nil
 			}
 		case err, ok := <-watcher.Errors:

task/orchestrator_test.go

@@ -319,7 +319,8 @@ func TestOrchestrator_waitForReadiness(t *testing.T) {
 		defer cancel()
 
 		o := Orchestrator{}
-		o.config.ReadinessFilePath = filepath.Join(t.TempDir(), "ready")
+		// Test a slash-separated path to ensure the readiness check handles it across different platforms
+		o.config.ReadinessFilePath = filepath.ToSlash(filepath.Join(t.TempDir(), "ready"))
 
 		go func() {
 			time.Sleep(250 * time.Millisecond)