Invoke-Chocolatey does not wait for result of choco.exe

[mwallner]

In certain scenarios, the boxstarter.extension get's "lost" during a package install with multiple choco commands, such as

choco install pkg1
choco install pkg2
choco install pkg3

without the extension being present, the process will stall because the confirmation option (-y) is not being added to the choco command.

This is most likely due to a bug in Invoke-Chocolatey

$p = Start-Process @pargs

Wait-Process -Id $p.id

will not work as expected when the started process exits quickly (even if the workload has been dispatched to a still running child-process)

[mwallner]

suggested fix: use ampersand operator instead of start-process
(currently unable to recall why I used start-process to begin with .. 🤔 )

Enter-BoxstarterLogable {

        $cd = [System.IO.Directory]::GetCurrentDirectory()
        try {
            $targetWdir = $((Get-Location).Path)
            Write-BoxstarterMessage "setting current directory location to $targetWdir" -Verbose
            [System.IO.Directory]::SetCurrentDirectory("$(Convert-Path $targetWdir)")
            
            Write-BoxstarterMessage "BoxstarterWrapper::Run($chocoArgs)..." -Verbose

            $chocoExe = Join-Path $env:ChocolateyInstall 'choco.exe'
        
            & $chocoExe @chocoArgs 2>&1 | Out-Null
            $exitCode = $LASTEXITCODE
                    

            Write-BoxstarterMessage "BoxstarterWrapper::Run => $exitCode" -Verbose
            [System.Environment]::ExitCode = $exitCode

        }
        finally {
            Write-BoxstarterMessage "restoring current directory location to $cd" -Verbose
            [System.IO.Directory]::SetCurrentDirectory($cd)
        }
            
    }