feat!: Simplifcations of the code

closes: #21

test: replace jest by vitest

chore: update all the dependencies and fix eslint / prettier

Author: lpatiny

.eslintrc.yml

@@ -0,0 +1,14 @@
+import cheminfo from 'eslint-config-cheminfo-typescript';
+import globals from 'globals';
+
+export default [
+  ...cheminfo,
+  {
+    languageOptions: {
+      globals: {
+        ...globals.node,
+      },
+    },
+    rules: {},
+  },
+];

eslint.config.mjs

@@ -20,7 +20,7 @@
     "prettier": "prettier --check src",
     "prettier-write": "prettier --write src",
     "test": "npm run test-only && npm run eslint && npm run prettier && npm run check-types",
-    "test-only": "jest --coverage",
+    "test-only": "vitest run --coverage",
     "tsc": "npm run clean && npm run tsc-cjs && npm run tsc-esm",
     "tsc-cjs": "tsc --project tsconfig.cjs.json",
     "tsc-esm": "tsc --project tsconfig.esm.json"
@@ -38,19 +38,19 @@
   "homepage": "https://github.com/cheminfo/arraybuffer-xml-parser#readme",
   "devDependencies": {
     "@types/he": "^1.2.3",
-    "@types/jest": "^29.5.12",
+    "@vitest/coverage-v8": "2.1.7",
     "cheminfo-build": "^1.2.0",
-    "eslint": "^8.57.0",
-    "eslint-config-cheminfo-typescript": "^13.0.0",
+    "eslint": "^9.16.0",
+    "eslint-config-cheminfo-typescript": "^17.0.0",
+    "globals": "^15.13.0",
     "he": "^1.2.0",
     "iobuffer": "^5.3.2",
-    "jest": "^29.7.0",
     "pako": "^2.1.0",
-    "prettier": "^3.3.2",
-    "rimraf": "^5.0.7",
-    "ts-jest": "^29.1.5",
-    "typescript": "^5.5.3",
-    "uint8-base64": "^0.1.1"
+    "prettier": "^3.4.1",
+    "rimraf": "^6.0.1",
+    "typescript": "^5.7.2",
+    "uint8-base64": "^0.1.1",
+    "vitest": "^2.1.7"
   },
   "dependencies": {
     "dynamic-typing": "^1.0.1"

jest.config.js

@@ -1,24 +1,48 @@
+import type { TagValueProcessor } from './traversable/defaultOptions';
+
 export type XMLNodeValue = string | Uint8Array | number | boolean;
+export type XMLAttributeValue = string | number | boolean;
 
 export class XMLNode {
   public tagName: string;
   public parent?: XMLNode;
   public children: Record<string, XMLNode[]>;
-  public attributes?: Record<string, XMLNode | boolean>;
-  public value?: XMLNodeValue;
+  public attributes?: Record<string, XMLAttributeValue>;
+  public bytes: Uint8Array;
   public startIndex: number;
+  private tagValueProcessor: TagValueProcessor;
+  private cachedValue?: XMLNodeValue;
   public constructor(
     tagName: string,
-    parent?: XMLNode,
-    value?: Uint8Array | string | undefined | number,
+    parent: XMLNode | undefined,
+    bytes: Uint8Array,
+    tagValueProcessor: TagValueProcessor,
   ) {
     this.tagName = tagName;
     this.parent = parent;
     this.children = Object.create(null); //child tags
     this.attributes = Object.create(null); //attributes map
-    this.value = value; //text only
+    this.bytes = bytes; //text only
+    this.tagValueProcessor = tagValueProcessor;
     this.startIndex = -1;
   }
+  public append(toAppend: Uint8Array): void {
+    if (this.bytes.length === 0) {
+      this.bytes = toAppend;
+      return;
+    }
+    const arrayConcat = new Uint8Array(this.bytes.length + toAppend.length);
+    arrayConcat.set(this.bytes);
+    arrayConcat.set(toAppend, this.bytes.length);
+    this.bytes = arrayConcat;
+  }
+  public get value(): any {
+    if (this.cachedValue === undefined) {
+      const value = this.tagValueProcessor(this.bytes, this);
+      this.cachedValue = value;
+    }
+    return this.cachedValue;
+  }
   public addChild(child: XMLNode) {
     if (Array.isArray(this.children[child.tagName])) {
       //already presents

package.json

@@ -1,3 +1,5 @@
+import { describe, it, expect } from 'vitest';
+
 import { parse } from '../parse';
 
 const encoder = new TextEncoder();

src/XMLNode.ts

@@ -1,3 +1,5 @@
+import { describe, it, expect } from 'vitest';
+
 import { parse } from '../parse.ts';
 
 const encoder = new TextEncoder();

src/__tests__/arrayModeSpec.test.ts

@@ -1,3 +1,4 @@
+import { describe, it, expect } from 'vitest';
 // import he from 'he';
 
 import { parse } from '../parse';
@@ -18,9 +19,8 @@ describe('XMLParser', () => {
     };
 
     const result = parse(xmlData, {
-      attributeNamePrefix: '',
+      attributeNameProcessor: (name) => name,
       ignoreAttributes: false,
-      dynamicTypingAttributeValue: true,
     });
 
     expect(result).toStrictEqual(expected);
@@ -42,9 +42,8 @@ describe('XMLParser', () => {
     };
 
     const result = parse(xmlData, {
-      attributeNamePrefix: '',
+      attributeNameProcessor: (name) => name,
       ignoreAttributes: false,
-      dynamicTypingAttributeValue: true,
     });
 
     expect(result).toStrictEqual(expected);
@@ -66,9 +65,8 @@ describe('XMLParser', () => {
     };
 
     const result = parse(xmlData, {
-      attributeNamePrefix: '',
+      attributeNameProcessor: (name) => name,
       ignoreAttributes: false,
-      dynamicTypingAttributeValue: true,
     });
 
     expect(result).toStrictEqual(expected);
@@ -91,9 +89,8 @@ describe('XMLParser', () => {
     };
 
     const result = parse(xmlData, {
-      attributeNamePrefix: '',
+      attributeNameProcessor: (name) => name,
       ignoreAttributes: false,
-      dynamicTypingAttributeValue: true,
       allowBooleanAttributes: true,
     });
 
@@ -118,7 +115,7 @@ describe('XMLParser', () => {
     };
 
     const result = parse(xmlData, {
-      attributeNamePrefix: '',
+      attributeNameProcessor: (name) => name,
       ignoreAttributes: false,
     });
 
@@ -143,7 +140,7 @@ describe('XMLParser', () => {
     };
 
     const result = parse(xmlData, {
-      attributeNamePrefix: '',
+      attributeNameProcessor: (name) => name,
       ignoreAttributes: false,
       ignoreNameSpace: true,
     });

src/__tests__/arrayWithExtendedPrototypePropsSpec.test.js

@@ -1,4 +1,5 @@
 import { decode as base64decode } from 'uint8-base64';
+import { test, expect } from 'vitest';
 
 import { parse } from '../parse.ts';
 // library to convert base64 <--> arrayBuffer: https://github.com/niklasvh/base64-arraybuffer/blob/master/src/index.ts
@@ -15,9 +16,8 @@ test('base64 parsing', () => {
 </binaryDataArray>`);
 
   let result = parse(xmlData, {
-    attributeNamePrefix: '',
+    attributeNameProcessor: (name) => name,
     tagValueProcessor: (value, node) => {
-      // console.log(node.parent.child.cvParam);
       if (node.tagName !== 'binary') return decoder.decode(value);
       const decoded = base64decode(value);
       // isLittleEndian and the data were encoded in littleEndian

src/__tests__/attributesSpec.test.ts

@@ -1,5 +1,7 @@
-import { readFileSync } from 'fs';
-import { join } from 'path';
+import { readFileSync } from 'node:fs';
+import { join } from 'node:path';
+
+import { describe, it, expect } from 'vitest';
 
 import { parse } from '../parse';
 
@@ -233,7 +235,6 @@ patronymic</person></root>`);
     const result = parse(xmlData, {
       ignoreAttributes: false,
       cdataTagName: '__cdata',
-      cdataPositddionChar: '',
     });
 
     expect(result).toStrictEqual(expected);