Skip to content

Commit bac3654

Browse files
committed
Move Shader from filename constructor back to glow
1 parent 1ea71bb commit bac3654

File tree

17 files changed

+50
-67
lines changed

17 files changed

+50
-67
lines changed

source/examples/bindless-textures/main.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,8 @@ class EventHandler : public ExampleWindowEventHandler, glowutils::AbstractCoordi
9494

9595
m_program = new glow::Program;
9696
m_program->attach(
97-
glowutils::createShaderFromFile(gl::GL_VERTEX_SHADER, "data/bindless-textures/shader.vert"),
98-
glowutils::createShaderFromFile(gl::GL_FRAGMENT_SHADER, "data/bindless-textures/shader.frag")
97+
glow::Shader::fromFile(gl::GL_VERTEX_SHADER, "data/bindless-textures/shader.vert"),
98+
glow::Shader::fromFile(gl::GL_FRAGMENT_SHADER, "data/bindless-textures/shader.frag")
9999
);
100100

101101
std::array<glow::TextureHandle, std::tuple_size<decltype(m_textures)>::value> handles;

source/examples/computeshader/main.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ void EventHandler::createAndSetupTexture()
168168
void EventHandler::createAndSetupShaders()
169169
{
170170
m_computeProgram = new glow::Program();
171-
m_computeProgram->attach(glowutils::createShaderFromFile(gl::GL_COMPUTE_SHADER, "data/computeshader/cstest.comp"));
171+
m_computeProgram->attach(glow::Shader::fromFile(gl::GL_COMPUTE_SHADER, "data/computeshader/cstest.comp"));
172172

173173
m_computeProgram->setUniform("destTex", 0);
174174
}

source/examples/gpu-particles/ComputeShaderParticles.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,9 @@ void ComputeShaderParticles::initialize()
7171

7272
m_drawProgram = new Program();
7373
m_drawProgram->attach(
74-
glowutils::createShaderFromFile(gl::GL_VERTEX_SHADER, "data/gpu-particles/points.vert")
75-
, glowutils::createShaderFromFile(gl::GL_GEOMETRY_SHADER, "data/gpu-particles/points.geom")
76-
, glowutils::createShaderFromFile(gl::GL_FRAGMENT_SHADER, "data/gpu-particles/points.frag"));
74+
glow::Shader::fromFile(gl::GL_VERTEX_SHADER, "data/gpu-particles/points.vert")
75+
, glow::Shader::fromFile(gl::GL_GEOMETRY_SHADER, "data/gpu-particles/points.geom")
76+
, glow::Shader::fromFile(gl::GL_FRAGMENT_SHADER, "data/gpu-particles/points.frag"));
7777

7878
m_positionsSSBO = new Buffer();
7979
m_velocitiesSSBO = new Buffer();
@@ -114,7 +114,7 @@ void ComputeShaderParticles::initialize()
114114

115115
m_quad = new glowutils::ScreenAlignedQuad(m_color);
116116
m_clear = new glowutils::ScreenAlignedQuad(
117-
glowutils::createShaderFromFile(gl::GL_FRAGMENT_SHADER, "data/gpu-particles/clear.frag"));
117+
glow::Shader::fromFile(gl::GL_FRAGMENT_SHADER, "data/gpu-particles/clear.frag"));
118118
}
119119

120120
void ComputeShaderParticles::reset()

source/examples/gpu-particles/FragmentShaderParticles.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ void FragmentShaderParticles::initialize()
6666

6767
// Create screen aligned quad for particle update
6868
m_quadUpdate = new ScreenAlignedQuad(
69-
createShaderFromFile(gl::GL_FRAGMENT_SHADER, "data/gpu-particles/particle.frag"),
69+
Shader::fromFile(gl::GL_FRAGMENT_SHADER, "data/gpu-particles/particle.frag"),
7070
m_texPositions );
7171
m_quadUpdate->program()->setUniform("vertices", 0);
7272
m_quadUpdate->program()->setUniform("velocities", 1);
@@ -88,15 +88,15 @@ void FragmentShaderParticles::initialize()
8888

8989
// Create screen aligned quads for clear and rendering
9090
m_clear = new ScreenAlignedQuad(
91-
createShaderFromFile(gl::GL_FRAGMENT_SHADER, "data/gpu-particles/clear.frag") );
91+
Shader::fromFile(gl::GL_FRAGMENT_SHADER, "data/gpu-particles/clear.frag") );
9292
m_quad = new ScreenAlignedQuad(m_colorBuffer);
9393

9494
// Create draw program
9595
m_drawProgram = new Program();
9696
m_drawProgram->attach(
97-
createShaderFromFile(gl::GL_VERTEX_SHADER, "data/gpu-particles/points_fragment.vert")
98-
, createShaderFromFile(gl::GL_GEOMETRY_SHADER, "data/gpu-particles/points.geom")
99-
, createShaderFromFile(gl::GL_FRAGMENT_SHADER, "data/gpu-particles/points.frag"));
97+
Shader::fromFile(gl::GL_VERTEX_SHADER, "data/gpu-particles/points_fragment.vert")
98+
, Shader::fromFile(gl::GL_GEOMETRY_SHADER, "data/gpu-particles/points.geom")
99+
, Shader::fromFile(gl::GL_FRAGMENT_SHADER, "data/gpu-particles/points.frag"));
100100
}
101101

102102
void FragmentShaderParticles::reset()

source/examples/gpu-particles/TransformFeedbackParticles.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ void TransformFeedbackParticles::initialize()
4444
reset();
4545

4646
m_transformFeedbackProgram = new glow::Program();
47-
m_transformFeedbackProgram->attach(glowutils::createShaderFromFile(gl::GL_VERTEX_SHADER, "data/gpu-particles/transformfeedback.vert"));
47+
m_transformFeedbackProgram->attach(glow::Shader::fromFile(gl::GL_VERTEX_SHADER, "data/gpu-particles/transformfeedback.vert"));
4848

4949
m_transformFeedbackProgram->link();
5050

@@ -53,9 +53,9 @@ void TransformFeedbackParticles::initialize()
5353

5454
m_drawProgram = new Program();
5555
m_drawProgram->attach(
56-
glowutils::createShaderFromFile(gl::GL_VERTEX_SHADER, "data/gpu-particles/points.vert")
57-
, glowutils::createShaderFromFile(gl::GL_GEOMETRY_SHADER, "data/gpu-particles/points.geom")
58-
, glowutils::createShaderFromFile(gl::GL_FRAGMENT_SHADER, "data/gpu-particles/points.frag"));
56+
glow::Shader::fromFile(gl::GL_VERTEX_SHADER, "data/gpu-particles/points.vert")
57+
, glow::Shader::fromFile(gl::GL_GEOMETRY_SHADER, "data/gpu-particles/points.geom")
58+
, glow::Shader::fromFile(gl::GL_FRAGMENT_SHADER, "data/gpu-particles/points.frag"));
5959

6060
m_vao = new VertexArrayObject();
6161
m_vao->bind();
@@ -90,7 +90,7 @@ void TransformFeedbackParticles::initialize()
9090

9191
m_quad = new glowutils::ScreenAlignedQuad(m_color);
9292
m_clear = new glowutils::ScreenAlignedQuad(
93-
glowutils::createShaderFromFile(gl::GL_FRAGMENT_SHADER, "data/gpu-particles/clear.frag"));
93+
glow::Shader::fromFile(gl::GL_FRAGMENT_SHADER, "data/gpu-particles/clear.frag"));
9494
}
9595

9696
void TransformFeedbackParticles::reset()

source/examples/simple-transformfeedback/main.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -181,12 +181,12 @@ void EventHandler::createAndSetupShaders()
181181
{
182182
m_shaderProgram = new glow::Program();
183183
m_shaderProgram->attach(
184-
glowutils::createShaderFromFile(gl::GL_VERTEX_SHADER, "data/transformfeedback/simple.vert")
185-
, glowutils::createShaderFromFile(gl::GL_FRAGMENT_SHADER, "data/transformfeedback/simple.frag"));
184+
glow::Shader::fromFile(gl::GL_VERTEX_SHADER, "data/transformfeedback/simple.vert")
185+
, glow::Shader::fromFile(gl::GL_FRAGMENT_SHADER, "data/transformfeedback/simple.frag"));
186186

187187
m_transformFeedbackProgram = new glow::Program();
188188
m_transformFeedbackProgram->attach(
189-
glowutils::createShaderFromFile(gl::GL_VERTEX_SHADER, "data/transformfeedback/transformfeedback.vert"));
189+
glow::Shader::fromFile(gl::GL_VERTEX_SHADER, "data/transformfeedback/transformfeedback.vert"));
190190
m_transformFeedbackProgram->setUniform("deltaT", 0.0f);
191191
}
192192

source/examples/ssbo/main.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ class EventHandler : public ExampleWindowEventHandler
4040
gl::glClearColor(0.2f, 0.3f, 0.4f, 1.f);
4141

4242

43-
m_quad = new glowutils::ScreenAlignedQuad(glowutils::createShaderFromFile(gl::GL_FRAGMENT_SHADER, "data/ssbo/ssbo.frag"));
43+
m_quad = new glowutils::ScreenAlignedQuad(glow::Shader::fromFile(gl::GL_FRAGMENT_SHADER, "data/ssbo/ssbo.frag"));
4444

4545
m_quad->program()->setUniform("maximum", 10);
4646
m_quad->program()->setUniform("rowCount", 10);

source/examples/tessellation/main.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -59,12 +59,12 @@ class EventHandler : public ExampleWindowEventHandler
5959

6060
m_sphere = new glow::Program();
6161
m_sphere->attach(
62-
glowutils::createShaderFromFile(gl::GL_VERTEX_SHADER, "data/tessellation/sphere.vert")
63-
, glowutils::createShaderFromFile(gl::GL_TESS_CONTROL_SHADER, "data/tessellation/sphere.tcs")
64-
, glowutils::createShaderFromFile(gl::GL_TESS_EVALUATION_SHADER, "data/tessellation/sphere.tes")
65-
, glowutils::createShaderFromFile(gl::GL_GEOMETRY_SHADER, "data/tessellation/sphere.geom")
66-
, glowutils::createShaderFromFile(gl::GL_FRAGMENT_SHADER, "data/tessellation/sphere.frag")
67-
, glowutils::createShaderFromFile(gl::GL_FRAGMENT_SHADER, "data/common/phong.frag"));
62+
glow::Shader::fromFile(gl::GL_VERTEX_SHADER, "data/tessellation/sphere.vert")
63+
, glow::Shader::fromFile(gl::GL_TESS_CONTROL_SHADER, "data/tessellation/sphere.tcs")
64+
, glow::Shader::fromFile(gl::GL_TESS_EVALUATION_SHADER, "data/tessellation/sphere.tes")
65+
, glow::Shader::fromFile(gl::GL_GEOMETRY_SHADER, "data/tessellation/sphere.geom")
66+
, glow::Shader::fromFile(gl::GL_FRAGMENT_SHADER, "data/tessellation/sphere.frag")
67+
, glow::Shader::fromFile(gl::GL_FRAGMENT_SHADER, "data/common/phong.frag"));
6868

6969
m_icosahedron = new glowutils::Icosahedron();
7070
m_agrid = new glowutils::AdaptiveGrid(16U);

source/examples/transparency/ABufferAlgorithm.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ void ABufferAlgorithm::initialize(const std::string & transparencyShaderFilePath
4242
glow::NamedString::create("/transparency/abuffer.glsl", new glow::File(transparencyShaderFilePath + "abuffer.glsl"));
4343

4444
m_program = new glow::Program();
45-
m_program->attach(glowutils::createShaderFromFile(gl::GL_FRAGMENT_SHADER, transparencyShaderFilePath + "abuffer.frag"));
45+
m_program->attach(glow::Shader::fromFile(gl::GL_FRAGMENT_SHADER, transparencyShaderFilePath + "abuffer.frag"));
4646
m_program->attach(vertexShader);
4747
if (geometryShader != nullptr) m_program->attach(geometryShader);
4848

@@ -63,7 +63,7 @@ void ABufferAlgorithm::initialize(const std::string & transparencyShaderFilePath
6363
m_counter = new glow::Buffer();
6464
m_counter->setName("A Buffer Counter");
6565

66-
m_quad = new glowutils::ScreenAlignedQuad(glowutils::createShaderFromFile(gl::GL_FRAGMENT_SHADER, transparencyShaderFilePath + "abuffer_post.frag"));
66+
m_quad = new glowutils::ScreenAlignedQuad(glow::Shader::fromFile(gl::GL_FRAGMENT_SHADER, transparencyShaderFilePath + "abuffer_post.frag"));
6767

6868
m_colorBuffer = createColorTex();
6969
m_postFbo = new glow::FrameBufferObject;

source/examples/transparency/GlBlendAlgorithm.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ void GlBlendAlgorithm::initialize(const std::string & transparencyShaderFilePath
1515
assert(vertexShader != nullptr);
1616

1717
m_program = new glow::Program();
18-
m_program->attach(glowutils::createShaderFromFile(gl::GL_FRAGMENT_SHADER, transparencyShaderFilePath + "glblend.frag"));
18+
m_program->attach(glow::Shader::fromFile(gl::GL_FRAGMENT_SHADER, transparencyShaderFilePath + "glblend.frag"));
1919
m_program->attach(vertexShader);
2020
if (geometryShader != nullptr) m_program->attach(geometryShader);
2121

0 commit comments

Comments
 (0)