common: fix bug in cList constructor #1229

Author: cdcseacave

apps/Viewer/FirstPersonControls.cpp

@@ -157,36 +157,22 @@ void FirstPersonControls::processMovement(double deltaTime) {
 	Eigen::Vector3d right = getRight();
 	Eigen::Vector3d up = Eigen::Vector3d(0, 1, 0); // World up for flying
 
-	bool moved = false;
-
 	// WASD movement
-	if (keys[GLFW_KEY_W]) {
+	if (keys[GLFW_KEY_W])
 		move(forward, velocity);
-		moved = true;
-	}
-	if (keys[GLFW_KEY_S]) {
+	if (keys[GLFW_KEY_S])
 		move(-forward, velocity);
-		moved = true;
-	}
-	if (keys[GLFW_KEY_A]) {
+	if (keys[GLFW_KEY_A])
 		move(-right, velocity);
-		moved = true;
-	}
-	if (keys[GLFW_KEY_D]) {
+	if (keys[GLFW_KEY_D])
 		move(right, velocity);
-		moved = true;
-	}
 
 	// Vertical movement (flying)
 	if (keys[GLFW_KEY_Q] || keys[GLFW_KEY_E]) {
-		if (keys[GLFW_KEY_Q]) {
+		if (keys[GLFW_KEY_Q])
 			move(-up, velocity);
-			moved = true;
-		}
-		if (keys[GLFW_KEY_E]) {
+		if (keys[GLFW_KEY_E])
 			move(up, velocity);
-			moved = true;
-		}
 	}
 }
 

apps/Viewer/Renderer.cpp

@@ -1132,9 +1132,6 @@ void Renderer::RenderCameras(const Window& window) {
 
 	cameraShader->Use();
 
-	// Get the currently selected camera from the window's camera
-	MVS::IIndex selectedCamID = window.GetCamera().GetCurrentCamID();
-
 	cameraVAO->Bind();
 	cameraEBO->Bind();
 

apps/Viewer/UI.cpp

@@ -748,10 +748,8 @@ void UI::ShowHelpDialog() {
 		// Detect macOS for platform-specific shortcuts
 		#ifdef __APPLE__
 		const bool isMacOS = true;
-		const char* cmdKey = "Cmd";
 		#else
 		const bool isMacOS = false;
-		const char* cmdKey = "Ctrl";
 		#endif
 
 		// File Operations

libs/Common/List.h

@@ -137,8 +137,11 @@ class cList
 
 	// construct a list from the contents of the range [first, last)
 	template <class InputIt>
-	cList(InputIt first, InputIt last, bool /*dummy*/) : _size(std::distance(first, last)), _vectorSize(_size), _vector((TYPE*)operator new[](static_cast<size_t>(_size) * sizeof(TYPE)))
+	cList(InputIt first, InputIt last, bool /*dummy*/) : _size(0), _vectorSize(std::distance(first, last)), _vector(NULL)
 	{
+		if (_vectorSize == 0)
+			return;
+		_vector = (TYPE*)(operator new[] (static_cast<size_t>(_vectorSize) * sizeof(TYPE)));
 		while (first != last)
 			Insert(*first++);
 	}

libs/MVS/Scene.cpp

@@ -802,7 +802,7 @@ bool Scene::EstimatePointCloudNormals(bool bRefine)
 	// estimate normals using the views per point
 	#ifdef SCENE_USE_OPENMP
 	#pragma omp parallel for
-	for (int64_t _ID=0; _ID<pointcloud.points.size(); ++_ID) {
+	for (int64_t _ID=0; _ID<(int64_t)pointcloud.points.size(); ++_ID) {
 		const IIndex ID(static_cast<IIndex>(_ID));
 	#else
 	FOREACH(ID, pointcloud.points) {
@@ -836,7 +836,7 @@ bool Scene::EstimatePointCloudNormals(bool bRefine)
 	bool bImagesReloaded(false);
 	#ifdef SCENE_USE_OPENMP
 	#pragma omp parallel for
-	for (int64_t _idx=0; _idx<images.size(); ++_idx) {
+	for (int64_t _idx=0; _idx<(int64_t)images.size(); ++_idx) {
 		const IIndex idx(static_cast<IIndex>(_idx));
 	#else
 	FOREACH(idx, images) {
@@ -952,7 +952,7 @@ bool Scene::EstimatePointCloudNormals(bool bRefine)
 
 	#ifdef SCENE_USE_OPENMP
 	#pragma omp parallel for
-	for (int64_t _ID=0; _ID<pointcloud.points.size(); ++_ID) {
+	for (int64_t _ID=0; _ID<(int64_t)pointcloud.points.size(); ++_ID) {
 		const IIndex ID(static_cast<IIndex>(_ID));
 	#else
 	FOREACH(ID, pointcloud.points) {