feat: Convert now returns the converted value on error

BREAKING CHANGE: It was previously returning 0 on error.

Author: ccoVeille

conversion.go

@@ -60,10 +60,10 @@ func Convert[NumOut Number, NumIn Number](orig NumIn) (NumOut, error) {
 	if isFloat64[NumIn]() {
 		floatOrig := float64(orig)
 		if math.IsInf(floatOrig, 1) || math.IsInf(floatOrig, -1) {
-			return 0, getRangeError[NumOut](orig)
+			return converted, getRangeError[NumOut](orig)
 		}
 		if math.IsNaN(floatOrig) {
-			return 0, errorHelper[NumOut]{
+			return converted, errorHelper[NumOut]{
 				value: orig,
 				err:   ErrUnsupportedConversion,
 			}
@@ -84,11 +84,11 @@ func Convert[NumOut Number, NumIn Number](orig NumIn) (NumOut, error) {
 
 		// TODO: check for numbers close to math.MaxFloat32
 
-		return 0, getRangeError[NumOut](orig)
+		return converted, getRangeError[NumOut](orig)
 	}
 
 	if !sameSign(orig, converted) {
-		return 0, getRangeError[NumOut](orig)
+		return converted, getRangeError[NumOut](orig)
 	}
 
 	// and compare
@@ -100,7 +100,7 @@ func Convert[NumOut Number, NumIn Number](orig NumIn) (NumOut, error) {
 	// convert back to the original type
 	cast := NumIn(converted)
 	if cast != base {
-		return 0, getRangeError[NumOut](orig)
+		return converted, getRangeError[NumOut](orig)
 	}
 
 	return converted, nil

conversion_test.go

@@ -529,8 +529,8 @@ func TestRequireConvert(t *testing.T) {
 
 	t.Run("test fail on error", func(t *testing.T) {
 		for name, tt := range map[string]TestRunner{
-			"negative": MapRequireConvertTest[int, uint8]{Input: -1, ExpectedTestFailure: true},
-			"overflow": MapRequireConvertTest[int, uint8]{Input: math.MaxInt, ExpectedTestFailure: true},
+			"negative": MapRequireConvertTest[int, uint8]{Input: -1, ExpectedTestFailure: true, ExpectedOutput: 255},
+			"overflow": MapRequireConvertTest[int, uint8]{Input: math.MaxInt, ExpectedTestFailure: true, ExpectedOutput: 255},
 		} {
 			t.Run(name, func(t *testing.T) {
 				tt.Run(t)

examples_test.go

@@ -14,11 +14,11 @@ func ExampleConvert() {
 	fmt.Println(c, err)
 
 	a := int8(-1)
-	i, err := safecast.Convert[uint](a)
+	i, err := safecast.Convert[uint16](a)
 	fmt.Println(i, err)
 
 	// Output:
 	// 17 <nil>
 	// 17 <nil>
-	// 0 conversion issue: -1 (int8) is less than 0 (uint): minimum value for this type exceeded
+	// 65535 conversion issue: -1 (int8) is less than 0 (uint16): minimum value for this type exceeded
 }