Skip to content

Commit 37a4483

Browse files
author
Dhruv Paranjape
authored
Consumer group: change logger level to warn (#14)
* Consumer group: change logger level to warn For errors that are retried we don't need to log them as errors but rather as warnings, since there is nothing actionable about these exceptions. * Update codeowners to backend-council Update gem version
1 parent 9d67a0c commit 37a4483

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

.github/CODEOWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
# https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners
22

33
# PATH OWNERS
4-
* @catawiki/fintech-backend
4+
* @catawiki/backend-council

lib/kafka/consumer_group.rb

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,12 +47,12 @@ def join
4747
join_group
4848
synchronize
4949
rescue NotCoordinatorForGroup
50-
@logger.error "Failed to find coordinator for group `#{@group_id}`; retrying..."
50+
@logger.warn "Failed to find coordinator for group `#{@group_id}`; retrying..."
5151
sleep 1
5252
@coordinator = nil
5353
retry
5454
rescue ConnectionError
55-
@logger.error "Connection error while trying to join group `#{@group_id}`; retrying..."
55+
@logger.warn "Connection error while trying to join group `#{@group_id}`; retrying..."
5656
sleep 1
5757
@cluster.mark_as_stale!
5858
@coordinator = nil
@@ -69,6 +69,7 @@ def leave
6969
coordinator.leave_group(group_id: @group_id, member_id: @member_id)
7070
end
7171
rescue ConnectionError
72+
@logger.warn "Connection error while leaving group `#{@group_id}`"
7273
end
7374

7475
def fetch_offsets
@@ -111,7 +112,7 @@ def heartbeat
111112
@logger.error "Error sending heartbeat: #{e}"
112113
raise HeartbeatError, e
113114
rescue NotCoordinatorForGroup
114-
@logger.error "Failed to find coordinator for group `#{@group_id}`; retrying..."
115+
@logger.warn "Failed to find coordinator for group `#{@group_id}`; retrying..."
115116
sleep 1
116117
@coordinator = nil
117118
retry
@@ -139,7 +140,7 @@ def join_group
139140

140141
@logger.info "Joined group `#{@group_id}` with member id `#{@member_id}`"
141142
rescue UnknownMemberId
142-
@logger.error "Failed to join group; resetting member id and retrying in 1s..."
143+
@logger.warn "Failed to join group; resetting member id and retrying in 1s..."
143144

144145
@member_id = ""
145146
sleep 1
@@ -184,7 +185,7 @@ def synchronize
184185
def coordinator
185186
@coordinator ||= @cluster.get_group_coordinator(group_id: @group_id)
186187
rescue GroupCoordinatorNotAvailable
187-
@logger.error "Group coordinator not available for group `#{@group_id}`"
188+
@logger.warn "Group coordinator not available for group `#{@group_id}`, retrying in 1s"
188189

189190
sleep 1
190191

lib/kafka/version.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# frozen_string_literal: true
22

33
module Kafka
4-
VERSION = "0.6.16"
4+
VERSION = "0.6.17"
55
end

0 commit comments

Comments
 (0)