[#225] Fix Totara compatibility bug with the core get_directory_size function

Author: Alex Damsted

classes/check/dirsizes.php

@@ -44,7 +44,13 @@ class dirsizes extends check {
     public function get_result(): result {
         global $CFG;
 
-        $sizedataroot = get_directory_size($CFG->dataroot);
+        // If Totara, use custom Totara function for compatibility.
+        if (!empty($CFG->totara_version)) {
+            $sizedataroot = $this->dirsize_totara('dataroot');
+        } else {
+            $sizedataroot = get_directory_size($CFG->dataroot);
+        }
+
         $summary = $sizedataroot;
         $details = "Shared paths:<br>";
         $details .= '$CFG->dataroot = ' . display_size($sizedataroot);
@@ -61,9 +67,9 @@ public function get_result(): result {
         return new result(result::INFO, $summary, $details);
     }
     /**
-     * Get a paths sizet
+     * Get a path's size
      * @param string $cfg the path to check
-     * @return string size for a path as html
+     * @return string $size for a path as html
      */
     private function dirsize(string $cfg) {
         global $CFG;
@@ -76,4 +82,46 @@ private function dirsize(string $cfg) {
         return "<br>\$CFG->{$cfg} = " . display_size($size);
     }
 
+    /**
+     * Get a path's size (compatible with Totara)
+     * @param string $cfg the path to check
+     * @return int $size size for a path as an integer
+     */
+    private function dirsize_totara(string $cfg): int {
+        global $CFG;
+        if (!property_exists($CFG, $cfg)) {
+            return 0;
+        }
+        $rootdir = $CFG->{$cfg};
+
+        if (!is_dir($rootdir)) {
+            // Must be a directory.
+            return 0;
+        }
+
+        if (!$dir = @opendir($rootdir)) {
+            // Can't open it for some reason.
+            return 0;
+        }
+
+        $size = 0;
+
+        while (false !== ($file = readdir($dir))) {
+            $firstchar = substr($file, 0, 1);
+            if ($firstchar == '.' or $file == 'CVS') {
+                continue;
+            }
+            $fullfile = $rootdir .'/'. $file;
+
+            $filesize = filesize($fullfile);
+            if ($filesize === false) {
+                continue;
+            }
+
+            $size += $filesize;
+        }
+        closedir($dir);
+
+        return $size;
+    }
 }