Skip to content

Commit 5f06f81

Browse files
committed
Update to Slevomat 8.16 and phpdoc-parser 2.
1 parent 8565240 commit 5f06f81

File tree

4 files changed

+14
-9
lines changed

4 files changed

+14
-9
lines changed

CakePHP/Sniffs/Commenting/TypeHintSniff.php

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
use PHPStan\PhpDocParser\Parser\PhpDocParser;
3333
use PHPStan\PhpDocParser\Parser\TokenIterator;
3434
use PHPStan\PhpDocParser\Parser\TypeParser;
35+
use PHPStan\PhpDocParser\ParserConfig;
3536

3637
/**
3738
* Verifies order of types in type hints
@@ -294,13 +295,16 @@ protected static function getValueNode(string $tagName, string $tagComment): Php
294295
{
295296
static $phpDocParser;
296297
if (!$phpDocParser) {
297-
$constExprParser = new ConstExprParser();
298-
$phpDocParser = new PhpDocParser(new TypeParser($constExprParser), $constExprParser);
298+
$config = new ParserConfig(usedAttributes: ['lines' => true, 'indexes' => true]);
299+
300+
$constExprParser = new ConstExprParser($config);
301+
$phpDocParser = new PhpDocParser($config, new TypeParser($config, $constExprParser), $constExprParser);
299302
}
300303

301304
static $phpDocLexer;
302305
if (!$phpDocLexer) {
303-
$phpDocLexer = new Lexer();
306+
$config = new ParserConfig(usedAttributes: ['lines' => true, 'indexes' => true]);
307+
$phpDocLexer = new Lexer($config);
304308
}
305309

306310
return $phpDocParser->parseTagValue(new TokenIterator($phpDocLexer->tokenize($tagComment)), $tagName);

CakePHP/ruleset.xml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -200,10 +200,11 @@
200200
<exclude name="SlevomatCodingStandard.TypeHints.PropertyTypeHint.UselessAnnotation"/>
201201
<exclude-pattern>*/tests/*</exclude-pattern>
202202
</rule>
203-
<rule ref="SlevomatCodingStandard.TypeHints.UnionTypeHintFormat">
203+
<rule ref="SlevomatCodingStandard.TypeHints.DNFTypeHintFormat">
204204
<properties>
205205
<property name="enable" type="boolean" value="true"/>
206-
<property name="withSpaces" value="no"/>
206+
<property name="withSpacesAroundOperators" value="no"/>
207+
<property name="withSpacesInsideParentheses" value="no"/>
207208
<property name="shortNullable" value="yes"/>
208209
<property name="nullPosition" value="last"/>
209210
</properties>

composer.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@
1919
},
2020
"require": {
2121
"php": ">=8.1.0",
22-
"phpstan/phpdoc-parser": "^1.4.5",
23-
"slevomat/coding-standard": "^8.15",
22+
"phpstan/phpdoc-parser": "^2.1.0",
23+
"slevomat/coding-standard": "^8.16",
2424
"squizlabs/php_codesniffer": "^3.9"
2525
},
2626
"require-dev": {

docs/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,14 +130,14 @@ SlevomatCodingStandard (43 sniffs)
130130
- SlevomatCodingStandard.PHP.UselessParentheses
131131
- SlevomatCodingStandard.PHP.UselessSemicolon
132132
- SlevomatCodingStandard.TypeHints.DeclareStrictTypes
133+
- SlevomatCodingStandard.TypeHints.DNFTypeHintFormat
133134
- SlevomatCodingStandard.TypeHints.LongTypeHints
134135
- SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue
135136
- SlevomatCodingStandard.TypeHints.ParameterTypeHint
136137
- SlevomatCodingStandard.TypeHints.ParameterTypeHintSpacing
137138
- SlevomatCodingStandard.TypeHints.PropertyTypeHint
138139
- SlevomatCodingStandard.TypeHints.ReturnTypeHint
139140
- SlevomatCodingStandard.TypeHints.ReturnTypeHintSpacing
140-
- SlevomatCodingStandard.TypeHints.UnionTypeHintFormat
141141
- SlevomatCodingStandard.Variables.DuplicateAssignmentToVariable
142142
- SlevomatCodingStandard.Variables.UnusedVariable
143143

@@ -174,4 +174,4 @@ Squiz (28 sniffs)
174174

175175
Zend (1 sniff)
176176
--------------
177-
- Zend.NamingConventions.ValidVariableName
177+
- Zend.NamingConventions.ValidVariableName

0 commit comments

Comments
 (0)