do not cache packages versions.

Author: tux-mind

cSploit/src/org/csploit/android/SettingsActivity.java

@@ -495,8 +495,6 @@ public void run() {
 
   private void onMsfPathChanged() {
     measureMsfSize();
-    System.updateLocalRubyVersion();
-    System.updateLocalMsfVersion();
     boolean haveMsf = false;
     File dir;
     File [] content;

cSploit/src/org/csploit/android/core/System.java

@@ -130,9 +130,6 @@ public class System
   private static String mSessionName = null;
 
   private static String mApkVersion = null;
-  private static String mCoreVersion = null;
-  private static String mRubyVersion = null;
-  private static String mMsfVersion = null;
 
   private static Object mCustomData = null;
 
@@ -715,40 +712,23 @@ private static String readFirstLine(String filePath) {
    * @return the version of the core, null if not present.
    */
   public static String getCoreVersion() {
-    if(mCoreVersion == null)
-      mCoreVersion = readFirstLine(getCorePath() + "/VERSION");
-    return mCoreVersion;
+    return readFirstLine(getCorePath() + "/VERSION");
   }
 
   /**
    * get version of installed ruby
    * @return the installed version of ruby
    */
   public static String getLocalRubyVersion() {
-    if(mRubyVersion ==null)
-      mRubyVersion = readFirstLine(getRubyPath() + "/VERSION");
-    return mRubyVersion;
-  }
-
-  public static void updateLocalRubyVersion() {
-    mRubyVersion =null;
-    getLocalRubyVersion();
+    return readFirstLine(getRubyPath() + "/VERSION");
   }
 
   /**
    * get version of installed MetaSploit Framework
    * @return the version of installed MetaSploit Framework
    */
   public static String getLocalMsfVersion() {
-    if(mMsfVersion ==null)
-      mMsfVersion = readFirstLine(getMsfPath() + "/VERSION");
-
-    return mMsfVersion;
-  }
-
-  public static void updateLocalMsfVersion() {
-    mMsfVersion = null;
-    getLocalMsfVersion();
+    return readFirstLine(getMsfPath() + "/VERSION");
   }
 
   public static boolean isServiceRunning(String name){

cSploit/src/org/csploit/android/core/UpdateService.java

@@ -1401,10 +1401,6 @@ else if (what_to_do == action.core_update)
         mCurrentTask.errorOccurred = exitForError = false;
       }
 
-      if(what_to_do==action.msf_update)
-        System.updateLocalMsfVersion();
-      if(what_to_do==action.ruby_update)
-        System.updateLocalRubyVersion();
       sendDone(what_to_do);
     } catch ( SecurityException e) {
       sendError(what_to_do, R.string.bad_permissions);