[a11y] Contextual consent - The bold text should be a heading.

[juliemoynatPro]

In the Contextuel consent section, the bold text ""YouTube videos" is inactive" should be a heading because it looks like a heading and it introduces content after (paragraph + button to allow cookies).

I understand that it's difficult to determine a heading level because you can't know the context in which it will be use. An idea is to use a level 6 heading (the last one) because it should be an inferior level in an article with headings (except if a video is after an existing level 6 heading but we don't have lower level…). What do you think?

Note: in the theme "système de design de l'État français", there is a heading for that text.

[felixgirault]

Hello,
I understand the issue, but I fear that the fix would still be a bit flaky, as it could introduce "holes" in the title hierarchy.
Maybe it could use a h6 by default, and allow the user to pass a custom level ?

<template 
  data-purpose="youtube" 
  data-contextual 
  data-contextual-heading="h3"
>
  <iframe src="https://www.youtube.com/embed/toto"></iframe>
</template>

[juliemoynatPro]

That's a good idea!

[felixgirault]

I found out this was actually already implemented 😅
I added tests and documentation so it is not hidden anymore #162

As you noted, the tag defaults to strong on the standard theme, whereas it defaults to h4 on DSFR.

Do you think it is worth changing the standard's theme default ?

[juliemoynatPro]

Ah! Good news! Thanks for the documentation.

In my opinion, there is no use case where this text could be something else than a heading. So I would recommend to change that strong into a h6 or other level heading. I still think that h6 is safer (even if it can create "holes", at least it would be inferior) if it's not configured by developers.