Skip to content

Better integration with ConstructionBase #29

@mattsignorelli

Description

@mattsignorelli

parameter group definitions, including properties which are not fields, should be more consistent with how ConstructionBase works so that Accessors can play nicely with promotion.

e.g. overriding Base.propertynames and trying to do an Accessors.set gives:

ERROR: The `RectangleParams` type defines custom properties: it has `propertynames` overloaded.
Please define `ConstructionBase.setproperties(::RectangleParams, ::NamedTuple)` to set its properties.

This will also make it more consistent with e.g. only settable vs only gettable properties.

Note that properties != "virtual properties" which are only at the line element level.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions