Skip to content

Commit 00342b6

Browse files
fix(redirect): [PM-30810] Https Redirection for Cloud Users - Cleaned up claude's implementation to prioritize clarity.
1 parent ae47e33 commit 00342b6

2 files changed

Lines changed: 12 additions & 3 deletions

File tree

src/Core/Constants.cs

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,17 @@ public static class Constants
3838
/// </summary>
3939
public static readonly string[] BitwardenCloudDomains = ["bitwarden.com", "bitwarden.eu", "bitwarden.pw"];
4040

41+
/// <summary>
42+
/// Server permitted SSO callback redirect URIs for mobile clients.
43+
/// </summary>
44+
public static readonly string[] BitwardenMobileSsoCallbackUris =
45+
[
46+
"bitwarden://sso-callback",
47+
"https://bitwarden.com/sso-callback",
48+
"https://bitwarden.eu/sso-callback",
49+
"https://bitwarden.pw/sso-callback",
50+
];
51+
4152
/// <summary>
4253
/// Used by IdentityServer to identify our own provider.
4354
/// </summary>

src/Identity/IdentityServer/ApiClient.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,9 +83,7 @@ public ApiClient(
8383
}
8484
else if (id == "mobile")
8585
{
86-
RedirectUris = new[] { "bitwarden://sso-callback" }
87-
.Concat(Constants.BitwardenCloudDomains.Select(d => $"https://{d}/sso-callback"))
88-
.ToArray();
86+
RedirectUris = Constants.BitwardenMobileSsoCallbackUris;
8987
PostLogoutRedirectUris = new[] { "bitwarden://logged-out" };
9088
}
9189

0 commit comments

Comments
 (0)