Describe the bug
A clear and concise description of what the bug is.
The .glightbox-open class, which is used to prevent scrolling when glightbox is opened:
is currently being added to both the HTML element and the body element:
|
_.addClass(body, 'glightbox-open'); |
And it hides all elements in body that overflow their container, causing "background flashes" as elements disappear then reappear when opening and closing GLightbox.
Could we either remove the class from the body element (adding it to html should do the trick?), or switch to overflow: clip instead?
Are you able to reproduce the bug in the demo site
Yes|No.
To Reproduce
Steps to reproduce the behavior:
- Go to '...'
- Click on '....'
- Scroll down to '....'
- See error
Expected behavior
A clear and concise description of what you expected to happen.
Post the code you are using
Help me solve issues faster, if I can copy paste your code I can try to reproduce and fix the bug faster.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop:
- OS: [e.g. iOS]
- Browser [e.g. chrome, safari]
- Version [e.g. 22]
Smartphone:
- Device: [e.g. iPhone6]
- OS: [e.g. iOS8.1]
- Browser [e.g. stock browser, safari]
- Version [e.g. 22]
Describe the bug
A clear and concise description of what the bug is.
The
.glightbox-openclass, which is used to prevent scrolling when glightbox is opened:glightbox/src/postcss/glightbox.css
Line 406 in e52876c
is currently being added to both the HTML element and the body element:
glightbox/src/js/glightbox.js
Line 200 in e52876c
And it hides all elements in body that overflow their container, causing "background flashes" as elements disappear then reappear when opening and closing GLightbox.
Could we either remove the class from the body element (adding it to html should do the trick?), or switch to
overflow: clipinstead?Are you able to reproduce the bug in the demo site
Yes|No.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Post the code you are using
Help me solve issues faster, if I can copy paste your code I can try to reproduce and fix the bug faster.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop:
Smartphone: