-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Closed
Labels
A-RenderingDrawing game state to the screenDrawing game state to the screenC-Code-QualityA section of code that is hard to understand or changeA section of code that is hard to understand or changeD-TrivialNice and easy! A great choice to get started with BevyNice and easy! A great choice to get started with BevyS-Ready-For-ImplementationThis issue is ready for an implementation PR. Go for it!This issue is ready for an implementation PR. Go for it!X-UncontroversialThis work is generally agreed uponThis work is generally agreed upon
Description
Follow-up: this trait is too broadly named. Something like
ImageVolumewould be better.
Originally posted by @alice-i-cecile in #23160 (comment)
We tend to keep our type and trait names quite descriptive, such that this makes sense in a global "game engine context".
This trait is only for an obscure property of images, not for "audio volume" or "physical volume".
I would also happily accept a refactor to eliminate it!
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-RenderingDrawing game state to the screenDrawing game state to the screenC-Code-QualityA section of code that is hard to understand or changeA section of code that is hard to understand or changeD-TrivialNice and easy! A great choice to get started with BevyNice and easy! A great choice to get started with BevyS-Ready-For-ImplementationThis issue is ready for an implementation PR. Go for it!This issue is ready for an implementation PR. Go for it!X-UncontroversialThis work is generally agreed uponThis work is generally agreed upon
Type
Projects
Status
Done