Skip to content

bevy_image::Volume uses too broad of a name #23184

@alice-i-cecile

Description

@alice-i-cecile

Follow-up: this trait is too broadly named. Something like ImageVolume would be better.

Originally posted by @alice-i-cecile in #23160 (comment)

We tend to keep our type and trait names quite descriptive, such that this makes sense in a global "game engine context".

This trait is only for an obscure property of images, not for "audio volume" or "physical volume".

I would also happily accept a refactor to eliminate it!

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-RenderingDrawing game state to the screenC-Code-QualityA section of code that is hard to understand or changeD-TrivialNice and easy! A great choice to get started with BevyS-Ready-For-ImplementationThis issue is ready for an implementation PR. Go for it!X-UncontroversialThis work is generally agreed upon

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions