Address PR review feedback

- Add hey todo/timetrack/journal list to API-COVERAGE.md recordings row
- Guard against nil legacy client in TUI fetchTopic
- Update legacy client comment to reflect current gap operations
- Fix drafts agent_notes to reference subjects instead of kind
- Add tests for calendar helpers (findPersonalCalendarID, unwrapCalendars, filterRecordingsByType)

Author: jeremy

API-COVERAGE.md

@@ -14,7 +14,7 @@ The legacy `internal/client/` is used only for HTML-scraping gap operations mark
 | `/laterbox.json` | GET | SDK `Boxes().GetLaterbox` | `hey box laterbox` | covered |
 | `/bubblebox.json` | GET | SDK `Boxes().GetBubblebox` | `hey box bubblebox` | covered |
 | `/calendars.json` | GET | SDK `Calendars().List` | `hey calendars` | covered |
-| `/calendars/{id}/recordings.json` | GET | SDK `Calendars().GetRecordings` | `hey recordings <calendar-id>` | covered |
+| `/calendars/{id}/recordings.json` | GET | SDK `Calendars().GetRecordings` | `hey recordings <calendar-id>`, `hey todo list`, `hey timetrack list`, `hey journal list` | covered |
 | `/topics/{id}/entries` | GET (HTML) | Legacy `GetTopicEntries` | `hey threads <id>` | gap: SDK Entry lacks body |
 | `/entries/drafts.json` | GET | SDK `Entries().ListDrafts` | `hey drafts` | covered |
 | `/topics/messages` | POST | SDK `Messages().Create` | `hey compose` | covered |

internal/cmd/drafts.go

@@ -22,7 +22,7 @@ func newDraftsCommand() *draftsCommand {
 		Use:   "drafts",
 		Short: "List drafts",
 		Annotations: map[string]string{
-			"agent_notes": "Returns saved draft messages with IDs, summaries, and kind.",
+			"agent_notes": "Returns saved draft messages with IDs, summaries, and subjects.",
 		},
 		Example: `  hey drafts
   hey drafts --limit 10

internal/cmd/sdk_test.go

@@ -3,6 +3,8 @@ package cmd
 import (
 	"testing"
 	"time"
+
+	"github.com/basecamp/hey-sdk/go/pkg/generated"
 )
 
 func TestFormatTimestampUTC(t *testing.T) {
@@ -51,3 +53,83 @@ func TestFormatDateZero(t *testing.T) {
 		t.Errorf("formatDate(zero) = %q, want empty", got)
 	}
 }
+
+func TestFindPersonalCalendarIDByFlag(t *testing.T) {
+	calendars := []generated.Calendar{
+		{Id: 1, Name: "Work", Personal: false},
+		{Id: 110, Name: "", Personal: true},
+	}
+	id, err := findPersonalCalendarID(calendars)
+	if err != nil {
+		t.Fatalf("unexpected error: %v", err)
+	}
+	if id != 110 {
+		t.Errorf("findPersonalCalendarID = %d, want 110", id)
+	}
+}
+
+func TestFindPersonalCalendarIDByName(t *testing.T) {
+	calendars := []generated.Calendar{
+		{Id: 1, Name: "Work", Personal: false},
+		{Id: 42, Name: "Personal", Personal: false},
+	}
+	id, err := findPersonalCalendarID(calendars)
+	if err != nil {
+		t.Fatalf("unexpected error: %v", err)
+	}
+	if id != 42 {
+		t.Errorf("findPersonalCalendarID = %d, want 42", id)
+	}
+}
+
+func TestFindPersonalCalendarIDNotFound(t *testing.T) {
+	calendars := []generated.Calendar{
+		{Id: 1, Name: "Work", Personal: false},
+	}
+	_, err := findPersonalCalendarID(calendars)
+	if err == nil {
+		t.Fatal("expected error, got nil")
+	}
+}
+
+func TestUnwrapCalendarsNil(t *testing.T) {
+	result := unwrapCalendars(nil)
+	if result != nil {
+		t.Errorf("unwrapCalendars(nil) = %v, want nil", result)
+	}
+}
+
+func TestUnwrapCalendars(t *testing.T) {
+	payload := &generated.CalendarListPayload{
+		Calendars: []generated.CalendarWithRecordingChangesUrl{
+			{Calendar: generated.Calendar{Id: 1, Name: "Work"}},
+			{Calendar: generated.Calendar{Id: 2, Name: "Personal"}},
+		},
+	}
+	result := unwrapCalendars(payload)
+	if len(result) != 2 {
+		t.Fatalf("len = %d, want 2", len(result))
+	}
+	if result[0].Id != 1 || result[1].Id != 2 {
+		t.Errorf("IDs = [%d, %d], want [1, 2]", result[0].Id, result[1].Id)
+	}
+}
+
+func TestFilterRecordingsByType(t *testing.T) {
+	resp := &generated.CalendarRecordingsResponse{
+		"Calendar::Todo":         {{Id: 1, Title: "Todo"}},
+		"Calendar::JournalEntry": {{Id: 2, Title: "Journal"}},
+	}
+	todos := filterRecordingsByType(resp, "Calendar::Todo")
+	if len(todos) != 1 || todos[0].Id != 1 {
+		t.Errorf("unexpected todos: %v", todos)
+	}
+	missing := filterRecordingsByType(resp, "Calendar::TimeTrack")
+	if missing != nil {
+		t.Errorf("expected nil for missing type, got %v", missing)
+	}
+	nilResult := filterRecordingsByType(nil, "Calendar::Todo")
+	if nilResult != nil {
+		t.Errorf("expected nil for nil resp, got %v", nilResult)
+	}
+}

internal/tui/tui.go

@@ -73,7 +73,7 @@ type model struct {
 	width  int
 	height int
 	sdk    *hey.Client
-	legacy *client.Client // kept for gap operations (topic entry bodies)
+	legacy *client.Client // kept for gap operations (topic entries, journal fallback, relative URL fetches)
 	ctx    context.Context
 	cancel context.CancelFunc
 	styles styles
@@ -570,6 +570,9 @@ func (m model) fetchBox(boxID int) tea.Cmd {
 // fetchTopic uses the legacy client — SDK entries lack body content (Gap 1).
 func (m model) fetchTopic(topicID int, title string) tea.Cmd {
 	return func() tea.Msg {
+		if m.legacy == nil {
+			return errMsg{fmt.Errorf("topic view requires legacy client (SDK entries lack body content)")}
+		}
 		entries, err := m.legacy.GetTopicEntries(topicID)
 		if err != nil {
 			return errMsg{err}