Skip to content

Add zram estimation test #3688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
alexgg wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Add zram estimation test #3688

alexgg wants to merge 7 commits into from

Conversation

@alexgg
Copy link
Contributor

@alexgg alexgg commented Jun 17, 2025 •
edited
Loading

Related: https://github.com/product-os/github-runner-vm/pull/253

This will need github-runners to be updated to use the latest github-runner-vm as they are currently in:

  runner-jammy-1:
    image: ghcr.io/product-os/github-runner-vm:3.1.0-jammy

Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

alexgg added 7 commits June 17, 2025 15:36
@alexgg
os-helpers-fs: add a function to estimate zram compression sizes
7446d80 
Change-type: patch
Signed-off-by: Alex Gonzalez <[email protected]>
@alexgg
initrdscripts: migrate: use an estimated compressed size for raw image
b698458 
The memory check before a migration run was not taking into account
that the tmp directory is now compressed ram.

This change approximates the compressed size of the raw image which is
the biggest in the calculation. The rest of the file sizes are left as
is to provide some buffer for approximation failures and not to complicate
the logic excessively.

Change-type: patch
Signed-off-by: Alex Gonzalez <[email protected]>
@alexgg
os-helpers-fs: move logic to assert luks encrypted partitions
26fa347 
The logic to assert encrypted partitions was being implemented in a
device specific way as part of cryptsetup - move it to common code so
that this does not need to be re-implemented for every device type.

Change-type: patch
Signed-off-by: Alex Gonzalez <[email protected]>
@alexgg
initrdscripts: cryptsetup-efi-tmp: use common encrypted partition ass…
b143c8a 
…erts

Use the shared helper functions to assert encrypted partitions.

Note that the new functions have introduced some refactoring so that
they can be used in the general case.

Change-type: patch
Signed-off-by: Alex Gonzalez <[email protected]>
@alexgg
busybox: add conv support in dd
7b37dcd 
This is used from the initramfs of flasher devices to erase the disk
of secrets.

Change-type: patch
Signed-off-by: Alex Gonzalez <[email protected]>
@alexgg
os-helpers: add os-helpers-fs test
df9ba96 
Change-type: patch
Signed-off-by: Alex Gonzalez <[email protected]>
@alexgg
[DEBUG]
5315a41
@alexgg alexgg marked this pull request as draft June 17, 2025 18:59
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com June 17, 2025 18:59 — with GitHub Actions Inactive
@alexgg alexgg mentioned this pull request Jun 17, 2025
Merged
6 tasks
@alexgg alexgg had a problem deploying to sign.balena-cloud.com June 17, 2025 19:00 — with GitHub Actions Failure
@deploynaut
Copy link

deploynaut bot commented Jun 17, 2025

One or more environments require approval before deploying workflow runs.

Maintainers, please inspect changes carefully for improper handling of secrets or other sensitive information.

To approve pending deployments, submit an approved review, or a commented review with /deploy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexgg