-
Notifications
You must be signed in to change notification settings - Fork 122
[POC] Double root partition sizes in the initrd #3684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mtoman
wants to merge
1
commit into
master
Choose a base branch
from
mtoman/growroot
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this moment, root partition sizes are defined at build time and we have no way to resize them on running devices.
On its own, this is a nontrivial problem to solve:
This patch adds an initrd script that doubles the root partition sizes by doing the following:
This is obviously a one-time operation. Once rootA has eaten the space originally occupied by rootB, the same trick can't work again. It also creates ambiguity between partition layouts - newly provisioned devices with bigger partitions defined at build time will end up with a different partition layout than devices that went through the growroot procedure in the field.
We do accept this as a compromise as on some device types we need to grow the root partitions on existing devices without reprovisioning.
Contributor checklist
Change-typepresent on at least one commitSigned-off-byis presentReviewer Guidelines