-
Notifications
You must be signed in to change notification settings - Fork 122
os-helpers-fs: move logic to assert partition structure to helper file #3679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| # 0: Success | ||
| # 1: Failure | ||
| # | ||
| estimate_size_in_zram() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @alexgg, I'm wondering why what was a one liner, became this more complex function?
It's seems that this function measures the size that a file is going to take in zram by compressing the file manually and counting the blocks.
Was there a bug with the du command?
Why is it always zram compressed now? vs never compressed (du -cb)?
Is it that we were we were actually requiring the raw image size, when we actually needed the compressed one?
If not what was the problem and how was it solved?
I haven't yet really gotten into HUP and updating the OS and the associated complexity sorry if I'm lacking a bit of context.
Move the generic dmcrypt partition assertion logic. This is slightly different as paritions do not contain meta-data that can identify the encrypted partitions so dmsetup is used after the partition is mounted.
Change-type: patch
Contributor checklist
Change-typepresent on at least one commitSigned-off-byis presentReviewer Guidelines